Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 6 Jun 2022 14:30:07 -0700
From:   Darren Hart <darren@os.amperecomputing.com>
To:     Zhou Guanghui <zhouguanghui1@huawei.com>
Cc:     akpm@linux-foundation.org, rppt@kernel.org, will@kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-arm-kernel@lists.infradead.org, xuqiang36@huawei.com
Subject: Re: [PATCH v3] memblock,arm64: Expand the static memblock memory
 table
Message-ID: <Yp5x32CsI/BBcHf9@fedora>
References: <20220527091832.63489-1-zhouguanghui1@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220527091832.63489-1-zhouguanghui1@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LZL0/eYoUCVeuYbhT/xshG6w3yHZvs5Rw4Ozro7tGWAx+R4IhEA2hCaaIgXD?=
 =?us-ascii?Q?6gXysmThmVGoNW/ehyigEp0v2Mifa4klT7lmOLMAimz12m0s+jhCmSCzdVeY?=
 =?us-ascii?Q?YZc9O48zx1eWwx4cDeafpaLLlu9xzbFiYNJxeTud93Ly0deCDJT8FS+kX1rB?=
 =?us-ascii?Q?nl3x22i8LqfzkrpLeQgjPDRi3R6Zy6KHTJxNkiLc6P+gGSVrJEWWfoRGgBiw?=
 =?us-ascii?Q?hRsHFOE8Yn2wsYjh5Yq49tdSm/PdfkKVr10mmdjcy/g5ZtRVZAGj9KyHCAnY?=
 =?us-ascii?Q?LP1xbla5zEIF38R3Y24DZVzuT18+DO0OzD8Zyn+h8FsmVo1ZfmggGD1Bji56?=
 =?us-ascii?Q?iY2p4Xv78u4tRSyxO0FWN57vDELoPQYPC/jjRQjF61LlR0TPl7yJf98L+3/X?=
 =?us-ascii?Q?aFhGKneamDUR1AKng6B+Z4kthqM3uNQmtd9PFju2QLO2AMn8wDmoHUx4wSqK?=
 =?us-ascii?Q?dZvxPfv/Mx6J7Y9SnvdGfM27beaiFKNdBu6bjaD3DIw6Qm1dZ3d87hWrwkQU?=
 =?us-ascii?Q?vbHLf0S1XfOsBnQ3kxQAW6C7IpaF5cqlyJJRdBkaMDh706T638OEE29M7E/p?=
 =?us-ascii?Q?Fzniojz30vwpLe2nWaEkcj9h9gUgLa8WknvkpNzr2DIvxvOvzkWqGKkVBl6U?=
 =?us-ascii?Q?G03lltWz25dFRqpQOh+F2bc5TAALV5bRGaO61Ql0iNZR+9Bpem54YHOq7FUG?=
 =?us-ascii?Q?vGVmQv9ui0eqP5juFhvM09lObmzCMpKYVXtVOh39NpcBoKiKBwuvoR66ynK2?=
 =?us-ascii?Q?DjiuEi+/vepJDQD/CKYPVLz+prS+aBmpQxXM8iPCdyd10XRSVcFhnfsOpnBt?=
 =?us-ascii?Q?5h6bYXWrXfP8OVhS44aFdyNxCJPZHvlbU8GZ4o8UWKdiB4zc9+UiCNM2mWBZ?=
 =?us-ascii?Q?IKug5rHPyiRY5NUd0ltXnCf+MCoHAgf+BTUVJfyTnUfJ0wUQKclIGgYTn0h3?=
 =?us-ascii?Q?b0tKR3fgVSWj+6C5tbCbhiC1iS0PXP+PyNcHfX9gUHyuAFWzLshsT0rjqA6h?=
 =?us-ascii?Q?jbTxb2cKURJ31jucrsx27YKwGCVrowjSnrIW2SjVytSs9ILhbxB9ReQiBkQa?=
 =?us-ascii?Q?zXfKR+1Jkrlb/Vg44fVhSRzznCmhBLBOuItrCLTlrt3zBEf8s0WUaFH30vdO?=
 =?us-ascii?Q?4UySH0plZVAg3PdbEVmSfMfNKNgO30dy71j3ptbRPP7Wkm/HGli+x0yEu5y/?=
 =?us-ascii?Q?gwRFhNaJtOY8GE15yxgvLI/Rsp1/3Gv1pwNilP9IXY63wMmWwOWAmgy8gT9q?=
 =?us-ascii?Q?o7VTJUAGSppn3yWbJ2TKdfEmGoSNOMV8KE//U7zyjRSWBmUAbi/zq3aGh0dc?=
 =?us-ascii?Q?vbfrdNhZZ1WfNd1EzwfqK0xoEGaNHiDxHvccj6bcc9bU/E5hpd/JAUZ9Zv8q?=
 =?us-ascii?Q?LsK2j01fbJ2TDoHWlDyT/o2DyRMyT65BCta/yt1LkukWr7k8NlgcnMSpckFT?=
 =?us-ascii?Q?ZVXat2NoAHePI0XL5NPHT/fDvV1qXiySSjT8enX+/luUOpolUZGknxkzbQRh?=
 =?us-ascii?Q?Xe6JOtBD3PffioYLD/9Vg0PiY//U1t7h0Fi9qSLDKMaGv9g0cFPQYHFb6uq8?=
 =?us-ascii?Q?cY6E10x/SpTY3It24dikz67DFDM+EtiEXfHGOwlHX17s/+IWtYKB0LHQDg7H?=
 =?us-ascii?Q?xyAJxwDI5tz6jNZZ38LXbD8RV66Ah6V+Hk6P1bG/iRfLT5RW35kUDl9BlDr+?=
 =?us-ascii?Q?e/kFCfVw4OyTxb5SZkjs2qLquldAlAFqx71vmhvmnqUaBkTSUESKFdO7wbqL?=
 =?us-ascii?Q?JWSA4YLdqOEW7+We1ywB0T0G6ScX7m+v7hxz9gU8NdjCRq1yxgQ5?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5620373-7cbb-43c3-c860-08da4803bbe2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR01MB2638.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2022 21:30:10.3931
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PMesN1+O2I48SXLtlR+zhYucmv49QMNEPItBa++o42g1WGdXWZkVDgssMMTPcX/Cvs6KOcanjowz32MwkkqoftJU2K6ygUdkHaXFSZeDagNFZ0VDJT2VsEcZaiq3LCCW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR01MB2773
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 27, 2022 at 09:18:32AM +0000, Zhou Guanghui wrote:
> In a system using HBM, a multi-bit ECC error occurs, and the BIOS
> will mark the corresponding area (for example, 2 MB) as unusable.
> When the system restarts next time, these areas are not reported
> or reported as EFI_UNUSABLE_MEMORY. Both cases lead to an increase
> in the number of memblocks, whereas EFI_UNUSABLE_MEMORY leads to a
> larger number of memblocks.
> 
> For example, if the EFI_UNUSABLE_MEMORY type is reported:
> ...
> memory[0x92]    [0x0000200834a00000-0x0000200835bfffff], 0x0000000001200000 bytes on node 7 flags: 0x0
> memory[0x93]    [0x0000200835c00000-0x0000200835dfffff], 0x0000000000200000 bytes on node 7 flags: 0x4
> memory[0x94]    [0x0000200835e00000-0x00002008367fffff], 0x0000000000a00000 bytes on node 7 flags: 0x0
> memory[0x95]    [0x0000200836800000-0x00002008369fffff], 0x0000000000200000 bytes on node 7 flags: 0x4
> memory[0x96]    [0x0000200836a00000-0x0000200837bfffff], 0x0000000001200000 bytes on node 7 flags: 0x0
> memory[0x97]    [0x0000200837c00000-0x0000200837dfffff], 0x0000000000200000 bytes on node 7 flags: 0x4
> memory[0x98]    [0x0000200837e00000-0x000020087fffffff], 0x0000000048200000 bytes on node 7 flags: 0x0
> memory[0x99]    [0x0000200880000000-0x0000200bcfffffff], 0x0000000350000000 bytes on node 6 flags: 0x0
> memory[0x9a]    [0x0000200bd0000000-0x0000200bd01fffff], 0x0000000000200000 bytes on node 6 flags: 0x4
> memory[0x9b]    [0x0000200bd0200000-0x0000200bd07fffff], 0x0000000000600000 bytes on node 6 flags: 0x0
> memory[0x9c]    [0x0000200bd0800000-0x0000200bd09fffff], 0x0000000000200000 bytes on node 6 flags: 0x4
> memory[0x9d]    [0x0000200bd0a00000-0x0000200fcfffffff], 0x00000003ff600000 bytes on node 6 flags: 0x0
> memory[0x9e]    [0x0000200fd0000000-0x0000200fd01fffff], 0x0000000000200000 bytes on node 6 flags: 0x4
> memory[0x9f]    [0x0000200fd0200000-0x0000200fffffffff], 0x000000002fe00000 bytes on node 6 flags: 0x0
> ...
> 
> The EFI memory map is parsed to construct the memblock arrays before
> the memblock arrays can be resized. As the result, memory regions
> beyond INIT_MEMBLOCK_REGIONS are lost.
> 
> Allow overriding memblock.memory array size with architecture defined
> INIT_MEMBLOCK_MEMORY_REGIONS and make arm64 to set
> INIT_MEMBLOCK_MEMORY_REGIONS to 1024 when CONFIG_EFI is enabled.
> 
> Signed-off-by: Zhou Guanghui <zhouguanghui1@huawei.com>
> Acked-by: Mike Rapoport <rppt@linux.ibm.com>

Tested on Ampere Altra, resolving this issue as observed internally. I didn't
perform the test myself, but representing it here as a point of contact:

Tested-by: Darren Hart <darren@os.amperecomputing.com>

-- 
Darren Hart
Ampere Computing / OS and Kernel