Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 7 Jun 2022 12:09:23 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        michael@amarulasolutions.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 07/13] can: slcan: set bitrate by CAN device driver
 API
Message-ID: <20220607100923.odtfxpoupz66zlku@pengutronix.de>
References: <20220607094752.1029295-1-dario.binacchi@amarulasolutions.com>
 <20220607094752.1029295-8-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="evlblvdpykbg7ppi"
Content-Disposition: inline
In-Reply-To: <20220607094752.1029295-8-dario.binacchi@amarulasolutions.com>
Precedence: bulk


--evlblvdpykbg7ppi
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 07.06.2022 11:47:46, Dario Binacchi wrote:
> It allows to set the bitrate via ip tool, as it happens for the other
> CAN device drivers. It still remains possible to set the bitrate via
> slcand or slcan_attach utilities. In case the ip tool is used, the
> driver will send the serial command to the adapter.
>=20
> The struct can_bittiming_const and struct can_priv::clock.freq has been
> set with empirical values =E2=80=8B=E2=80=8Bthat allow you to get a corre=
ct bit timing, so
> that the slc_do_set_bittiming() can be called.

The CAN framework supports setting of fixed bit rates. Look for
can327_bitrate_const in

| https://lore.kernel.org/all/20220602213544.68273-1-max@enpas.org/

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--evlblvdpykbg7ppi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKfI9AACgkQrX5LkNig
010NZwf+JWg6xvugVyjZcc5tcPU4ayE2K4Z9BcyeMSfFWwVCObD8APUzDwcQy+as
XH36+DPh0unr2XVGYKaaWV9SEeDAWTXkbchB5gH1LOBn1HnMY/kezSZY33FZRq1y
mwoorfFTiMDgvnnH3Je3+mDPVf7jyxrWbjYEjuicfhhD4ot/X3gDfWxLgT7jwfDR
AsOYRfpmvL/7YOB4suMSPS511xMjrBdjVoeuTzLv7O0lRa/UWDdK1RXQXIDqeWLK
6lMSmQD8hAjCk//jzMdbQqzCLpBtLe2ficPAOSy4FUd/qzl3/20AszoOXaSD5cAG
92g3AEgfHzKaHVSB1AHYDYrijMIL2g==
=49Aq
-----END PGP SIGNATURE-----

--evlblvdpykbg7ppi--