Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 7 Jun 2022 18:15:15 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mark Gross <markgross@kernel.org>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        linux-watchdog@vger.kernel.org, Enrico Weigelt <lkml@metux.net>,
        Gerd Haeussler <gerd.haeussler.ext@siemens.com>
Subject: Re: [PATCH v3 0/4] simatic-ipc additions to p2sb apl lake gpio
Message-ID: <20220607181515.3f1e240c@md1za8fc.ad001.siemens.net>
In-Reply-To: <Yp9sLePHn9RqcXcU@smile.fi.intel.com>
References: <20220513083652.974-1-henning.schild@siemens.com>
        <You1KI78zbXmApm+@smile.fi.intel.com>
        <Yp9sLePHn9RqcXcU@smile.fi.intel.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GAJMkJ4CqRM+YBCe3MsgG6puDP5DCQcx0ArSxws+4ssKFrqqLIYQGRljZY3S?=
 =?us-ascii?Q?4ya2RjZNCGaKNITFNofjh4Vr+b1ubGiw7CMZxQ6TMln1c/a7bI6DBlhv7l55?=
 =?us-ascii?Q?mK6zJHCEGFDlGK3XAZUnjLPYw9klAneLP/C6H/Ure0o4BKVkTtvG4tczw5Wz?=
 =?us-ascii?Q?RyQSL0jDKtQFYKuhJoJn2KkSLsGtY4Jzvv1V/o+1rijFALNyoJm+m6SVjzLb?=
 =?us-ascii?Q?sEVBEr1HcbPT1ysoeDgNU4TW0bfZ/w5ojuTB7xjpbNckv1IavIUQcBWxACLx?=
 =?us-ascii?Q?GNrdai7qB6GwN2s83PeGlLj6oEpbQY6YhGLGM/+Az9rSFEQbpMXO6dZ9poET?=
 =?us-ascii?Q?92ioo+Ewv50CocY2n/9EYQi138XUmps/Mf54cZaFgKzNV2unz2dIZDw4T6fj?=
 =?us-ascii?Q?4MMz4lnXMXGvFW8hCKN7a/zL/xVpon5/cNlx2zvRwuZSKs5YjE1Hj0WjVB9V?=
 =?us-ascii?Q?JkFL0F+vOddLlJC5TNHZOZyadIVelg3HGej7HctcV/LGgvbrMrinFOiUYP4u?=
 =?us-ascii?Q?bwaI44XizEp/MERFdyXFO1ftrP5DoJtlyzUdXHSzCMcfc2clLLcqI8mrHeGC?=
 =?us-ascii?Q?C5RmUn1Wrtd7q1z61xbU87ysqbLS4g3Qe7bW8iPg21vvqCtff0CcndSh8dUw?=
 =?us-ascii?Q?/U4DX2L7h/DfKVBZjE2q1q1gWoqZzUOnMDQ9hrxWbljnTQTnZLze5iFVPUtj?=
 =?us-ascii?Q?s1GZz2KJXCz5jxRMOgTisZsR/mjgZZKI3RGUVy4r/0sJfbjPnCWUrMEeQ+sb?=
 =?us-ascii?Q?rrt10+kjyvAculZOkj2jCtEUaU7WXGNJKujeSsXOyIbi44GDxtoxrgxxF9HD?=
 =?us-ascii?Q?o7QyTDwXzqyS7QILAAD0AImnq0awom+K1xy+PowOaEMP1LCk3UHUD1ASeOMm?=
 =?us-ascii?Q?DhFyvqwSclXJokU+NPrw2phYVPu+AslR3SN+fBTcTUczCqPIeCc1p1Ph9/RC?=
 =?us-ascii?Q?9EPX4HDGvFSlzavEV7HcmgTQETlmUc35atCenSWyh5OJp+Tj36zi2loKsWi6?=
 =?us-ascii?Q?dSPIjb+OF8cz6wI2HYeCjnNJoQyrzc0lOasddR1xotrAwsEDv+Df6/RKJfRM?=
 =?us-ascii?Q?T7+fRY0c0uuzjuvwf5h6gBOsucpH5PhFp5pHLVGXNmooC1rqs6Gshp6UFHC3?=
 =?us-ascii?Q?POyFrwXiy7Vk1lEwi3ae2nOcQytC3L6hWI1z8ratLAMfu/XSWdoxXplLnlOW?=
 =?us-ascii?Q?c5IpHn2cL4lUm7ehXuYu7QgomNr/qQK3Ux81b0psmhIZ5KuBRazf8TdcnX28?=
 =?us-ascii?Q?lua/Uex8QRLt5kCIA7rQnBVm0CEsfiU//OT2JCJae8fS6DRYVtqkbzxJYT2L?=
 =?us-ascii?Q?pPiN7o6+mgVsbF1dD8RRUElhpmpllZ2XKWkVSPfrRww7e9xuEtXPRUgEWqGa?=
 =?us-ascii?Q?jkv+IA9CheuA6Ir//SGn7IBsMRNZUHE2A66Zhn1GWi59aKfkmNwwPUk31JTD?=
 =?us-ascii?Q?OeP12IXBuwoI3hwIkf9EzZrFVP1EpfyPapTDsWze8rpmeBWAMQr5uTan349b?=
 =?us-ascii?Q?0MrjvkPV3oyXAhnNFx9jj+dsWfW5tg3RAx7lP5Xak87Pp5OkHEG/BX3OyTQp?=
 =?us-ascii?Q?nAvZimxkNkJkvP+2APt9IIrdGandZUBuQ8Go3JIsUhCiLZK7rGgEnvsCA1OB?=
 =?us-ascii?Q?1qfpTMB1IZBWyZApbQ/XmFaroiG5Bz2Kd4rvvkI2dvjlRs+hFHUUQGW0qgas?=
 =?us-ascii?Q?0NODR90n4WSXsJClQjuKMpkbtBIIWHG0Xprf44vF0S8Q0PqkW81uN3bCYY32?=
 =?us-ascii?Q?RGuAfEmSjCAz2dZ9ruiSYvNIDIEcpgY=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c3267f1-42f7-4ffd-b7c0-08da48a0e9a5
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 16:15:18.0738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r1PqwnESrXZ2seLUYrN1rz6+ZmFnW++28tFMFBAKgRq3fsDk7V3iwfVtMMouIhNfqVfs68UbQJrYZ7xLON+PZYDfK/72Bg1pb1V5c6/5BJg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR10MB2325
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Tue, 7 Jun 2022 18:18:05 +0300
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Mon, May 23, 2022 at 07:24:08PM +0300, Andy Shevchenko wrote:
> > On Fri, May 13, 2022 at 10:36:48AM +0200, Henning Schild wrote:  
> > > changed since v2:
> > >  - put GPIO led module under same config switch
> > >  - some style changes from review
> > >  - init gpios with gpiod_get_index and drop gpiod_set_value
> > >  - drop bogus "if" from watchdog Kconfig
> > > 
> > > changed since v1:
> > >  - rebased
> > >  - split p1 into p1-3
> > > 
> > > This switches the simatic-ipc modules to using the upcoming p2sb 
> > > interface introduced by Andy with 
> > > "platform/x86: introduce p2sb_bar() helper".
> > > The series relies on these p2sb changes already applied and Andy
> > > will likely take them into his series at some point.
> > > 
> > > It also switches to one apollo lake device to using gpio leds.  
> > 
> > Hmm... This series misses LEDS maintainer. Okay, I will include
> > them when sending v6 after v5.19-rc1.  
> 
> I have sent v6 [1], please make sure everything is okay.

I received that and had a quick look over my bits. That all looked like
i sent it so i have no reason to doubt it would be working as expected.

In the coming two weeks i will not be able to get my hands on hardware,
so can not test but am pretty sure it is not needed another time.

regards,
Henning
 
> [1]:
> https://lore.kernel.org/platform-driver-x86/20220606164138.66535-1-andriy.shevchenko@linux.intel.com/