Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp1771527iof; Tue, 7 Jun 2022 11:07:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynNntlre0BEHbDd5Ij31dO5FatnvDGU6bRTWgaRNTKvtUzTJy1yNEAwAutwr7hdDY/ASeZ X-Received: by 2002:a05:6402:703:b0:42d:d347:a586 with SMTP id w3-20020a056402070300b0042dd347a586mr35552890edx.316.1654625261404; Tue, 07 Jun 2022 11:07:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654625261; cv=none; d=google.com; s=arc-20160816; b=Hoas7w7ZkgeLqIG03+1b21NNosv8TMmjT0GICFD+tWhwIEQ/ASVlbTedr01RphbrQN al3bSHyw78szEGlRcYjyCKcNkzcQsQzwq3iuT90aV+aqHqVcqMO9LghMJgSnvMsrH1SF T2aKCPQj04B1NzXg7H12isrxg2zTz0CRQv6CRRx0AKaegg4vBHts4XoqQmqgUL2GFhwy XCd82u9K7MckHSe4vRnGyGD38LTblQM+r+RJxXK/p2wfDt2CVODFrufed+0niqfvJJOX VjnyI2gaV4qrPbn0ldDOIL2oas0qfiGC7IvRFVV9/OEX+gvotvWP65Ie2oaASKEwskA7 wl9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Eyn/86c6liF5nYWGh9VyLqwQursjArpq+vyMDFNlc6Q=; b=VSJumDt8kIip6vwbquR8uB9qwWq7l9sHrBW2EkDm1K10JuzU45dympZRvF9cThj5RF pQq7eGrfiPTu8K1dioeGLGLBor9kT+tSK8d3O21+sodCHCfpAOKzGmNmujFkZ39aw2Ud GEY1X9kCs2Q1EzAFy2SQX2g2EezqlbP2fjoH1zKNVu1lYaa+kdoYIC6Do1HeZxUivwmE OVbDD+YRVyzDrhW+yfgxO3akoKfH6jr7MUE+MVhZCF+ZX8MgEY+63bzUbsnRChEHWnlY sp9sslCFKqgO+uPpcIX8BWY+vkJshzmKpJTqcMFxOcsmLOfVN8LCtkBOdbByB6p2f/aI QCwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lJSgL87N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f18-20020a056402355200b0042f9ff7beadsi5137edd.320.2022.06.07.11.07.10; Tue, 07 Jun 2022 11:07:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lJSgL87N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242683AbiFGLQP (ORCPT + 99 others); Tue, 7 Jun 2022 07:16:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242665AbiFGLQM (ORCPT ); Tue, 7 Jun 2022 07:16:12 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBD14396B2; Tue, 7 Jun 2022 04:16:10 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id u12-20020a17090a1d4c00b001df78c7c209so20546111pju.1; Tue, 07 Jun 2022 04:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Eyn/86c6liF5nYWGh9VyLqwQursjArpq+vyMDFNlc6Q=; b=lJSgL87NXAVkX4HsOGSumdR1cCQzgHG+hwOLjOuEvSSOnDvzXbBcK1qSGnr85+iGiI sIemmp+Qo8//8HwMOpA8byQpBC8n0ahRFcl/w0Vd6zJLLg6ezB+SV0TqW42pCwF/+jxa cqVuV30rPHvPd0GRB/19ILrquvbkwVD71D0nNjPizXqG7OAN9u/+EAWtVXK21b6SOYT3 l+ID6KKwRS26/HRZWyAal5DWRW/PCPJQwrauv6xYY8AX1keacnmJL1BjkmNGaHpPfklu H6LX6NrnnDI+V9C5M1c/pSsbBIdsKTuXr4wi/yYGDbAGe/OgwEeAV9uQvqGxJiamR4fv +e6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Eyn/86c6liF5nYWGh9VyLqwQursjArpq+vyMDFNlc6Q=; b=D0CS/EnkRH2PNBUCjNA2GtLp+MmL6EKjlVnN9jk9BW5dY1gv2aN1Ov+7YilRwWviGa pmofYQqCj1shcObuOxv8vHrlXw//muQYqhXHc0LGWaxGREb8iu3Ched2nv81ySRwhIff vJHbvauKzScD6OrEcrYub0cddpVe3bw3HkB36owpWAuswNQY0ttlaWoG5UwD3uy2Xcmj dEuRLW3jXs1rsP6kLsmUeNMMe5I49plmVz9i5vjq48KQGvAyhTpkCX0eEDn3C7dDobkT 9YpSF431dY7LXAwahrqPl8Py9xytQoeX+F+qoa9bIVnXpeVQz+EbqFCITZolh600U4YM ruHg== X-Gm-Message-State: AOAM532P5kKhf4h37Yyhym4kJ3DWRxISu1TnMl5iZwgl5ajEotu28uwu Kf676LBeC55qbCcWDPl6Syk= X-Received: by 2002:a17:902:f605:b0:14d:bd53:e2cd with SMTP id n5-20020a170902f60500b0014dbd53e2cdmr28383722plg.164.1654600570302; Tue, 07 Jun 2022 04:16:10 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id s23-20020a056a001c5700b0050dc762816fsm5213778pfw.73.2022.06.07.04.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 04:16:09 -0700 (PDT) From: Miaoqian Lin To: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] pinctrl: nomadik: Fix refcount leak in nmk_pinctrl_dt_subnode_to_map Date: Tue, 7 Jun 2022 15:16:01 +0400 Message-Id: <20220607111602.57355-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, SUSPICIOUS_RECIPS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak." Fixes: c2f6d059abfc ("pinctrl: nomadik: refactor DT parser to take two paths") Signed-off-by: Miaoqian Lin --- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index 640e50d94f27..f5014d09d81a 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -1421,8 +1421,10 @@ static int nmk_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, has_config = nmk_pinctrl_dt_get_config(np, &configs); np_config = of_parse_phandle(np, "ste,config", 0); - if (np_config) + if (np_config) { has_config |= nmk_pinctrl_dt_get_config(np_config, &configs); + of_node_put(np_config); + } if (has_config) { const char *gpio_name; const char *pin; -- 2.25.1