Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 6 Jun 2022 17:26:58 -0700
From:   Fangrui Song <maskray@google.com>
To:     Ian Rogers <irogers@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sedat Dilek <sedat.dilek@gmail.com>, llvm@lists.linux.dev,
        Sebastian Ullrich <sebasti@nullri.ch>
Subject: Re: [PATCH] perf unwind: Fix uninitialized variable
Message-ID: <20220607002658.zkbs4c37ihmivcmn@google.com>
References: <20220607000851.39798-1-irogers@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20220607000851.39798-1-irogers@google.com>
Precedence: bulk

On 2022-06-06, Ian Rogers wrote:
>ret may be uninitialized on error goto paths.
>
>Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
>Fixes: dc2cf4ca866f ("perf unwind: Fix segbase for ld.lld linked objects")
>Signed-off-by: Ian Rogers <irogers@google.com>

Thanks. Sorry for my mistake...

Reviewed-by: Fangrui Song <maskray@google.com>

>---
> tools/perf/util/unwind-libunwind-local.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
>index 37622699c91a..6e5b8cce47bf 100644
>--- a/tools/perf/util/unwind-libunwind-local.c
>+++ b/tools/perf/util/unwind-libunwind-local.c
>@@ -174,7 +174,7 @@ static int elf_section_address_and_offset(int fd, const char *name, u64 *address
> 	Elf *elf;
> 	GElf_Ehdr ehdr;
> 	GElf_Shdr shdr;
>-	int ret;
>+	int ret = -1;
>
> 	elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL);
> 	if (elf == NULL)
>-- 
>2.36.1.255.ge46751e96f-goog
>