Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a3a9d315-3b40-832a-8901-9adcbca1016a@139.com>
Date:   Tue, 7 Jun 2022 17:31:43 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as a
 module build error.
To:     Yupeng Li <liyupeng@zbhlos.com>, chenhc@lemote.com,
        ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org
Cc:     linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
        caizp2008@163.com
References: <20220607021702.3224369-1-liyupeng@zbhlos.com>
From:   HU Zeyuan <huzeyuan139@139.com>
In-Reply-To: <20220607021702.3224369-1-liyupeng@zbhlos.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hello,

If you want to submit patches,please send the email to the correct 
maintainer(s),and CC the correct mailing list(s).

Zeyuan

在 2022/6/7 10:17, Yupeng Li 写道:
>    set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
>    undefined error,fix cpu_hwmon compile options to be bool.Some kernel
>    compilation error information is as follows:
> 
>    Checking missing-syscalls for N32
>    CALL    scripts/checksyscalls.sh
>    Checking missing-syscalls for O32
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/checksyscalls.sh
>    CHK     include/generated/compile.h
>    CC [M]  drivers/platform/mips/cpu_hwmon.o
>    Building modules, stage 2.
>    MODPOST 200 modules
> ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92：__modpost] 错误 1
> make: *** [Makefile:1261：modules] 错误 2
> 
> Signed-off-by: Yupeng Li <liyupeng@zbhlos.com>
> ---
>   drivers/platform/mips/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index b3ae30a4c67b..c2f1ede1caca 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -16,7 +16,7 @@ menuconfig MIPS_PLATFORM_DEVICES
>   if MIPS_PLATFORM_DEVICES
>   
>   config CPU_HWMON
> -	tristate "Loongson CPU HWMon Driver"
> +	bool "Loongson CPU HWMon Driver"
>   	depends on LOONGSON_MACH3X
>   	select HWMON
>   	default y