Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764487AbXESXRR (ORCPT ); Sat, 19 May 2007 19:17:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756384AbXESXRE (ORCPT ); Sat, 19 May 2007 19:17:04 -0400 Received: from ug-out-1314.google.com ([66.249.92.175]:6389 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758225AbXESXRD (ORCPT ); Sat, 19 May 2007 19:17:03 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=doeHwfIttFYtbwizDSpEOsbRTACGv5pXqKc53vAz3sN4Gi9657k59O2LAcBvzRji5VuwLGZf1GxWmR4NJRmWCwVbRIz6u2CH+Zi9/M/trkijmlNKx3o9EmULfEhIcA3QQDPx6ynP0qsfNj6OCIZxBDOGPYsSM5OGqVpl1vW++IY= Message-ID: Date: Sun, 20 May 2007 04:47:01 +0530 From: "Satyam Sharma" To: "Adrian Bunk" Subject: Re: RFC: kconfig select warnings bogus? Cc: "Andrew Morton" , "Sam Ravnborg" , LKML , "Roman Zippel" In-Reply-To: <20070519230537.GI6291@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070519151523.GA26724@uranus.ravnborg.org> <20070519110944.2a52061e.akpm@linux-foundation.org> <20070519230537.GI6291@stusta.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1965 Lines: 42 On 5/20/07, Adrian Bunk wrote: > On Sat, May 19, 2007 at 11:09:44AM -0700, Andrew Morton wrote: > > On Sat, 19 May 2007 17:15:23 +0200 Sam Ravnborg wrote: > > > > > We see a lot of these lately: > > > GEN /home/bor/build/linux-2.6.22/Makefile > > > scripts/kconfig/conf -s arch/i386/Kconfig > > > drivers/macintosh/Kconfig:116:warning: 'select' used by config symbol 'PMAC_APM_EMU' refers to undefined symbol 'SYS_SUPPORTS_APM_EMULATION' > > > drivers/net/Kconfig:2283:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' > > > drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE' > > > drivers/input/mouse/Kconfig:182:warning: 'select' used by config symbol 'MOUSE_ATARI' refers to undefined symbol 'ATARI_KBD_CORE' > > > > > > > > > Do this warning really add any value or should we just ignore them like this? > > > > > > > They always indicate Kconfig bugs, don't they? If so, we should keep the > > warning. > >... > > No, they aren't always. > > Look for example at the last one in drivers/input/mouse/Kconfig: > > config MOUSE_ATARI > tristate "Atari mouse" > depends on ATARI > select ATARI_KBD_CORE > > This is perfectly correct (the select'ed symbol is only unavailable when > the dependency can't be fulfilled), and all things to "fix" the warning > will make it worse. Not sure what you mean here. The select'ed symbol here is unavailable because not all arch's define it. However, the symbol that selects it is in drivers/input/... and hence run for all arch's. That's the simple issue here that is resolved by this fix. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/