Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764779AbXESXgo (ORCPT ); Sat, 19 May 2007 19:36:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756099AbXESXgh (ORCPT ); Sat, 19 May 2007 19:36:37 -0400 Received: from ug-out-1314.google.com ([66.249.92.174]:22539 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758011AbXESXgg (ORCPT ); Sat, 19 May 2007 19:36:36 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=aHMM0lZMa1BJeNdOzFVHRTR5mqZEZ+fp8+nx/obWsmFGRGspSgtC4pSZSCUUJArIeO1LpDpg8Ex66F3QFYv28Jud8qw91wj7cSoEBB7cPTgYt4fJs5bMOeBqoP8doYuVI96PPNirQiPP/hxN40DuRjBfEZiEnVmAjvLCp8j7sAM= Message-ID: Date: Sun, 20 May 2007 05:06:33 +0530 From: "Satyam Sharma" To: "Adrian Bunk" Subject: Re: RFC: kconfig select warnings bogus? Cc: "Andrew Morton" , "Sam Ravnborg" , LKML , "Roman Zippel" , "Kumar Gala" , "Simon Horman" In-Reply-To: <20070519232542.GL6291@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070519151523.GA26724@uranus.ravnborg.org> <20070519110944.2a52061e.akpm@linux-foundation.org> <20070519230940.GJ6291@stusta.de> <20070519232542.GL6291@stusta.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2646 Lines: 65 On 5/20/07, Adrian Bunk wrote: > On Sun, May 20, 2007 at 04:47:52AM +0530, Satyam Sharma wrote: > > On 5/20/07, Adrian Bunk wrote: > >> On Sun, May 20, 2007 at 04:19:12AM +0530, Satyam Sharma wrote: > >> >... > >> > A combined patch for all of those on top of 22-rc2 (adding > >> Signed-off-by's > >> > for original authors too): > >> >... > >> > --- a/arch/m68k/Kconfig 2007-05-20 04:11:47.000000000 +0530 > >> > +++ b/arch/m68k/Kconfig 2007-05-20 04:23:57.000000000 +0530 > >> > @@ -411,6 +411,7 @@ config STRAM_PROC > >> > > >> > config ATARI_KBD_CORE > >> > bool > >> > + default y if KEYBOARD_ATARI || MOUSE_ATARI > >> >... > >> > --- a/drivers/input/keyboard/Kconfig 2007-05-20 04:11:55.000000000 > >> +0530 > >> > +++ b/drivers/input/keyboard/Kconfig 2007-05-20 04:24:54.000000000 > >> +0530 > >> > @@ -167,7 +167,6 @@ config KEYBOARD_AMIGA > >> > config KEYBOARD_ATARI > >> > tristate "Atari keyboard" > >> > depends on ATARI > >> > - select ATARI_KBD_CORE > >> > help > >> > Say Y here if you are running Linux on any Atari and have a > >> keyboard > >> > attached. > >> > diff -ruNp a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig > >> > --- a/drivers/input/mouse/Kconfig 2007-05-20 04:11:55.000000000 > >> +0530 > >> > +++ b/drivers/input/mouse/Kconfig 2007-05-20 04:25:09.000000000 > >> +0530 > >> > @@ -179,7 +179,6 @@ config MOUSE_AMIGA > >> > config MOUSE_ATARI > >> > tristate "Atari mouse" > >> > depends on ATARI > >> > - select ATARI_KBD_CORE > >> > help > >> > Say Y here if you have an Atari and want its native mouse > >> > supported by the kernel. > >> >... > >> > >> This is a good example how "fixing" the warnings makes things worse... > > > > How? > > Consider ATARI_KBD_CORE was used by 20 drivers. > > Using select for such not user visible helper variables is a really nice > thing, and much more readable (and therefore much less likely to contain > bugs) than dependencies with tons of "||"'s. Well, the "default .. if .." kind of idiom is fairly common (I could say almost standard), in arch/.../config's. It's been used for some time, and for several symbols over there. But you're right that if 20 drivers used ATARI_KBD_CORE, we'd get tons of ugly "||"'s there, so perhaps we do need some kind of fix for this. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/