Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761522AbXETBES (ORCPT ); Sat, 19 May 2007 21:04:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756529AbXETBEI (ORCPT ); Sat, 19 May 2007 21:04:08 -0400 Received: from ug-out-1314.google.com ([66.249.92.174]:29478 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755763AbXETBEG (ORCPT ); Sat, 19 May 2007 21:04:06 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=k+AXwGmd5MuFuWX6w0o18gp1SaNe4U/fvfbn14REx9tu25mQg1DSJBVdDA9tlMFqC0DSI9DR/fBLRrnWzqbGk+OcUpnDzFcOZiHgob6o5/Z0ZwPnd9IziI+imXUaa15Qmbbp6oN0GMJgbgVSX85F0ykM73fz8enJwHzK10uRlL0= Message-ID: Date: Sun, 20 May 2007 06:34:01 +0530 From: "Satyam Sharma" To: "Stefan Richter" Subject: Re: RFC: kconfig select warnings bogus? Cc: "Andrew Morton" , "Sam Ravnborg" , LKML , "Roman Zippel" , "Kumar Gala" , "Simon Horman" , "Adrian Bunk" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070519151523.GA26724@uranus.ravnborg.org> <20070519110944.2a52061e.akpm@linux-foundation.org> <464F9A7B.1030708@s5r6.in-berlin.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 47 On 5/20/07, Satyam Sharma wrote: > On 5/20/07, Stefan Richter wrote: > > Satyam Sharma wrote: > > > A combined patch for all of those on top of 22-rc2 (adding Signed-off-by's > > > for original authors too): > > > > > > Signed-off-by: Kumar Gala > > > Signed-off-by: Simon Horman > > > Signed-off-by: Satyam Sharma > > > > [...] > > > > Adrian already commented on this. Let me just add that these above > > changes are in so far *totally wrong* as they remove the "depends on > > XYZ" which is implied by "select XYZ". > > Did you even try this patch? > > Did you try to select UCC_GETH and see if UCC_FAST got > automatically selected or not? > > Did you get any build problems (or bogus warnings, for that matter)? > > Have you ever looked into arch/.../Kconfig's? > > > Remember, "select" is like "depends on", just with the added twist that > > the 'make snafuconfig' scripts are instructed to (a) not hide the > > depending option from the user and (b) try to enable the dependency for > > the user if he tries to enable the depending option. > > This is precisely what happens with this patch too. > > Believe me, just go ahead and try it. > > Report any errors, dissatisfaction, etc, if any. > > Thanks. [ Just to add: ] You'll learn about the "default .. if .." Kconfig idiom after you try this, but when this patch works for you, an Acked-by would also be nice, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/