Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 7 Jun 2022 20:02:12 +0100
From:   Mark Brown <broonie@kernel.org>
To:     cy_huang <u0084500@gmail.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        lee.jones@linaro.org, dmitry.torokhov@gmail.com,
        lgirdwood@gmail.com, cy_huang@richtek.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-binding: mfd: Add Richtek RT5120 PMIC support
Message-ID: <Yp+gtJju1H+j88lE@sirena.org.uk>
References: <1654581161-12349-1-git-send-email-u0084500@gmail.com>
 <1654581161-12349-2-git-send-email-u0084500@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="GhgJliQVyO1woWPn"
Content-Disposition: inline
In-Reply-To: <1654581161-12349-2-git-send-email-u0084500@gmail.com>
Precedence: bulk


--GhgJliQVyO1woWPn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 07, 2022 at 01:52:38PM +0800, cy_huang wrote:

> +  richtek,enable-undervolt-hiccup:
> +    type: boolean
> +    description: |
> +      If used, under voltage protection trigger hiccup behavior, else latchup as
> +      default
> +
> +  richtek,enable-overvolt-hiccup:
> +    type: boolean
> +    description:
> +      Like as 'enable-uv-hiccup', it configures over voltage protection to
> +      hiccup, else latchup as default

Why would we not want to have these enabled?  Unless there's some cost
to having them on it seems safer and more helpful to look for problems
with regulation all the time, it might help debug a system.

--GhgJliQVyO1woWPn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKfoLQACgkQJNaLcl1U
h9CghwgAhKQP332Duy+3Mo0gptG0yFMJ8gqHIDJs+CdT0ySHCfs2UbGKLcwqX2dh
f27AiBrqexCG8V69PERvcQ9R+cl8hfqXHaU2RHEgLxn+ZAk5aYTxEkdXgEBR8ETb
KCyDNuoRL3nwXXgFAP5G63fQBm/y5ZnjI7yLhrs6WJ/mKjuwW62WSJj+19/sRizO
MaPGokov7fdjc9j7VIouUFu8uy0OToqLBteNICDjrixFQ8jeb9CaHjHhLYuYuLnT
N0cKI1pxV4b16vJQW174/ZG7EjusYXs6odzkv8JpP0pEcdYa1EDMGKo2rYpx2DEN
qRJNQ7ubpVDwad4URK5JKk1nHxw5tA==
=PnDB
-----END PGP SIGNATURE-----

--GhgJliQVyO1woWPn--