Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <9c457623-7a80-dad8-8ef8-2346b0a4f0a1@quicinc.com>
Date:   Tue, 7 Jun 2022 18:55:49 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [V4] serial: core: Do stop_rx in suspend path for console if
 console_suspend is disabled
Content-Language: en-CA
To:     Greg KH <gregkh@linuxfoundation.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>
CC:     <jirislaby@kernel.org>, <linux-serial@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_msavaliy@quicinc.com>,
        <dianders@chromium.org>, <mka@chromium.org>, <swboyd@chromium.org>
References: <1652692810-31148-1-git-send-email-quic_vnivarth@quicinc.com>
 <CGME20220523213246eucas1p2d0da08d931a996cd3410eda1c2fd48c0@eucas1p2.samsung.com>
 <bf7eec57-6ad6-2c1a-ea61-0e1d06fc77f5@samsung.com>
 <Yp9RCelSM9L+hpAV@kroah.com>
From:   Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
In-Reply-To: <Yp9RCelSM9L+hpAV@kroah.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/7/2022 6:52 PM, Greg KH wrote:
> On Mon, May 23, 2022 at 11:32:46PM +0200, Marek Szyprowski wrote:
>> Hi,
>>
>> On 16.05.2022 11:20, Vijaya Krishna Nivarthi wrote:
>>> For the case of console_suspend disabled, if back to back suspend/resume
>>> test is executed, at the end of test, sometimes console would appear to
>>> be frozen not responding to input. This would happen because, during
>>> resume, rx transactions can come in before system is ready, malfunction
>>> of rx happens in turn resulting in console appearing to be stuck.
>>>
>>> Do a stop_rx in suspend sequence to prevent this.
>>>
>>> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
>>> ---
>>> v4: moved the change to serial core to apply for all drivers
>>> v3: swapped the order of conditions to be more human readable
>>> v2: restricted patch to contain only stop_rx in suspend sequence
>>> v1: intial patch contained 2 additional unrelated changes in vicinity
>>> ---
>> This patch landed recently in linux-next as commit c9d2325cdb92
>> ("serial: core: Do stop_rx in suspend path for console if
>> console_suspend is disabled").
>>
>> Unfortunately it breaks console operation on my test systems after
>> system suspend/resume cycle if 'no_console_suspend' kernel parameter is
>> present. System properly resumes from suspend, the console displays all
>> the messages and even command line prompt, but then doesn't react on any
>> input. If I remove the 'no_console_suspend' parameter, the console is
>> again operational after system suspend/resume cycle. Before this patch
>> it worked fine regardless the 'no_console_suspend' parameter.
> Did this ever get resolved or do I need to revert this?

We have a resolution and I will be uploading a Fixes: patch today.

Thank you.

-Vijay/


>
> thanks,
>
> greg k-h