Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 7 Jun 2022 10:11:53 -0600
From:   Keith Busch <kbusch@kernel.org>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: add device name to warning in uuid_show()
Message-ID: <Yp94yTFrrkbBYqsj@kbusch-mbp.dhcp.thefacebook.com>
References: <20220607155555.8623-1-linux@weissschuh.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220607155555.8623-1-linux@weissschuh.net>
Precedence: bulk

On Tue, Jun 07, 2022 at 05:55:55PM +0200, Thomas Wei?schuh wrote:
>  	if (uuid_is_null(&ids->uuid)) {
> -		printk_ratelimited(KERN_WARNING
> -				   "No UUID available providing old NGUID\n");
> +		dev_warn_ratelimited(dev, "No UUID available providing old NGUID\n");
>  		return sysfs_emit(buf, "%pU\n", ids->nguid);

The line split was correct to prevent this overly long line. But otherwise,
this looks good, though I'm wondering why this needs to be printed every time
someone reads the attribute.