Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 7 Jun 2022 13:35:06 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Lukasz Majewski <lukma@denx.de>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
        Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 1/3] ASoC: wm8940: Remove warning when no plat data
Message-ID: <Yp9F+r1WryNFzyrM@sirena.org.uk>
References: <20220606154441.20848-1-lukma@denx.de>
 <Yp4iGvGFD9jo4WUP@sirena.org.uk>
 <20220606181731.04b6f771@ktm>
 <Yp4wzS0aLEo5werI@sirena.org.uk>
 <20220607143039.01cdff80@ktm>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VwEHQR+T8zP616/F"
Content-Disposition: inline
In-Reply-To: <20220607143039.01cdff80@ktm>
Precedence: bulk


--VwEHQR+T8zP616/F
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 07, 2022 at 02:30:39PM +0200, Lukasz Majewski wrote:
> > On Mon, Jun 06, 2022 at 06:17:31PM +0200, Lukasz Majewski wrote:
> > > > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote: =
=20

> > > My point is that - similar codec - wm8974 don't display such
> > > warnings. (this code was not updated/refactored for a quite long
> > > time). =20

> > Perhaps those drivers are buggy, or those devices lack this specific
> > configuration that's being adjusted?  The changelog should at least
> > address why the driver was warning about configuration being required
> > but it's safe to ignore that.

> With v4.4 from which I forward port those changes only the PXA
> 'stargate2' mach is using this codec.

> In this version there is no reference to 'vroi'.

That's equivalent to setting a value of 0 given the way platform data
works.

> I guess that one can provide the 'vroi' information via DTS nowadays if
> required.

Yes, that's what I'd expect.

--VwEHQR+T8zP616/F
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKfRfkACgkQJNaLcl1U
h9C+VQf/a2Lo4791u9dihgpYWy514oujclrH2q6cIYgSRs9nrNvyOBW46Lzfk6to
Bju+dCExmD48HfkH0jLbHI18b+nrtmH2NU6AD5qe9AFlGk/lVtEnECpV+bZBHpKu
DTEuq94BC1cMe6KWPapmGuoPLmzDw3PTbUu3hGIHm17hHpHzMIzHmOPpNdopO4Sx
YLRktN3V5F3T55l3KlGTsQKu46ddvNtWKzcBdZCu8APIHZtn9dQnTtdBcD0gtDQz
FYuiYZfbyIiVbmKdaU3P1Wqb1QN4wXCme7GXyJ5jrEqlNrMzTdcAkgfvkGu66hnf
EVNDP8a39faQa6wbv1xUu/AcvEDGUA==
=MyNE
-----END PGP SIGNATURE-----

--VwEHQR+T8zP616/F--