Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 7 Jun 2022 15:36:01 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Jiri Slaby <jslaby@suse.cz>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/36] tty/vt: consolemap: rename and document struct
 uni_pagedir
In-Reply-To: <20220607104946.18710-2-jslaby@suse.cz>
Message-ID: <46cbc044-5157-65d8-65f0-2ecbee908150@linux.intel.com>
References: <20220607104946.18710-1-jslaby@suse.cz> <20220607104946.18710-2-jslaby@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 7 Jun 2022, Jiri Slaby wrote:

> struct uni_pagedir contains 32 unicode page directories, so the name of
> the structure is a bit misleading. Rename the structure to uni_pagedict,
> so it looks like this:
> struct uni_pagedict
>   -> 32 page dirs
>      -> 32 rows
>        -> 64 glyphs
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---

The rename looks incomplete:

>  drivers/tty/vt/consolemap.c    | 47 ++++++++++++++++++++--------------
>  drivers/video/console/vgacon.c |  4 +--
>  include/linux/console_struct.h |  6 ++---
>  3 files changed, 33 insertions(+), 24 deletions(-)

vs

$ git grep -l vc_uni_pagedir
drivers/tty/vt/consolemap.c
drivers/tty/vt/vt.c
drivers/usb/misc/sisusbvga/sisusb_con.c
drivers/video/console/vgacon.c
drivers/video/fbdev/core/fbcon.c
include/linux/console_struct.h
$

???


-- 
 i.