Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <1654170291-29910-1-git-send-email-quic_c_sbhanu@quicinc.com> <20220602143405.GA2261501-robh@kernel.org>
In-Reply-To: <20220602143405.GA2261501-robh@kernel.org>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Tue, 7 Jun 2022 12:15:30 +0200
Message-ID: <CAPDyKFqpPcWwTyShOUZeJ+1KY1BZU5YMW8+3vamHaSikNyuEag@mail.gmail.com>
Subject: Re: [PATCH V5] dt-bindings: mmc: sdhci-msm: Add gcc resets strings
To:     Rob Herring <robh@kernel.org>
Cc:     Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>,
        krzysztof.kozlowski+dt@linaro.org, bhupesh.sharma@linaro.org,
        linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_rampraka@quicinc.com,
        quic_pragalla@quicinc.com, quic_sartgarg@quicinc.com,
        quic_nitirawa@quicinc.com, quic_sayalil@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 2 Jun 2022 at 16:34, Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Jun 02, 2022 at 05:14:51PM +0530, Shaik Sajida Bhanu wrote:
> > Add gcc hardware reset supported strings for qcom-sdhci controller
> >
> > Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > Changes since V4:
> >       - Updated Dt bindings changes YAML format as suggested by
> >         Ulf Hansson.
> >
> > Changes since V3:
> >       - Removed reset-names from DT bindings as suggested by
> >         Stephen Boyd.
> > ---
> >  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> > index e423633..5548c35 100644
> > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> > @@ -121,6 +121,9 @@ properties:
> >      description: A phandle to sdhci power domain node
> >      maxItems: 1
> >
> > +  resets:
> > +    description: Phandle and reset specifier for the device's reset.
>
> Don't need generic descriptions for common properties. What you do need
> is how many entries and what each entry is if more than one.

I guess we should also specify whether the reset is optional or required. Right?

Kind regards
Uffe