Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763397AbXETJnt (ORCPT ); Sun, 20 May 2007 05:43:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754910AbXETJnm (ORCPT ); Sun, 20 May 2007 05:43:42 -0400 Received: from caramon.arm.linux.org.uk ([217.147.92.249]:3979 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754864AbXETJnl (ORCPT ); Sun, 20 May 2007 05:43:41 -0400 Date: Sun, 20 May 2007 10:43:32 +0100 From: Russell King To: Adrian Bunk Cc: Andrew Morton , Sam Ravnborg , LKML , Roman Zippel Subject: Re: RFC: kconfig select warnings bogus? Message-ID: <20070520094332.GB9645@flint.arm.linux.org.uk> Mail-Followup-To: Adrian Bunk , Andrew Morton , Sam Ravnborg , LKML , Roman Zippel References: <20070519151523.GA26724@uranus.ravnborg.org> <20070519110944.2a52061e.akpm@linux-foundation.org> <20070519230537.GI6291@stusta.de> <20070519162239.1bcb03d6.akpm@linux-foundation.org> <20070520000235.GP6291@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070520000235.GP6291@stusta.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 36 On Sun, May 20, 2007 at 02:02:35AM +0200, Adrian Bunk wrote: > On Sat, May 19, 2007 at 04:22:39PM -0700, Andrew Morton wrote: > > On Sun, 20 May 2007 01:05:37 +0200 Adrian Bunk wrote: > > > > > Look for example at the last one in drivers/input/mouse/Kconfig: > > > > > > config MOUSE_ATARI > > > tristate "Atari mouse" > > > depends on ATARI > > > select ATARI_KBD_CORE > > > > > > This is perfectly correct (the select'ed symbol is only unavailable when > > > the dependency can't be fulfilled), and all things to "fix" the warning > > > will make it worse. > > > > If ATARI is unset then we shouldn't be generating the "'select' used by > > config symbol 'KEYBOARD_ATARI' refers to undefined symbol 'ATARI_KBD_CORE'" > > warnings, should we? > > Exactly. If we do that we need to try a million and one Kconfig option combinations to find undefined symbols. Not practical. (And no, allyconfig really doesn't hack it on non-x86 platforms, no matter how much people whinge that it should do. It's a pipedream to make it so.) -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/