Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220606134553.2919693-1-alvin@pqrs.dk> <20220606134553.2919693-4-alvin@pqrs.dk>
In-Reply-To: <20220606134553.2919693-4-alvin@pqrs.dk>
From:   Luiz Angelo Daros de Luca <luizluca@gmail.com>
Date:   Tue, 7 Jun 2022 10:17:56 -0300
Message-ID: <CAJq09z4f1DN1b=+QONT7ya5nXVQ6m8ZcMDVemmkduWc9mXSTRg@mail.gmail.com>
Subject: Re: [PATCH net-next 3/5] net: dsa: realtek: rtl8365mb: correct the
 max number of ports
To:     =?UTF-8?Q?Alvin_=C5=A0ipraga?= <alvin@pqrs.dk>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        =?UTF-8?Q?Alvin_=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Russell King <linux@armlinux.org.uk>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Em seg., 6 de jun. de 2022 =C3=A0s 10:46, Alvin =C5=A0ipraga <alvin@pqrs.dk=
> escreveu:
>
> From: Alvin =C5=A0ipraga <alsi@bang-olufsen.dk>
>
> The maximum number of ports is actually 11, according to two
> observations:
>
> 1. The highest port ID used in the vendor driver is 10. Since port IDs
>    are indexed from 0, and since DSA follows the same numbering system,
>    this means up to 11 ports are to be presumed.
>
> 2. The registers with port mask fields always amount to a maximum port
>    mask of 0x7FF, corresponding to a maximum 11 ports.
>  /* valid for all 6-port or less variants */

It makes sense for the family. The 10-ports variants have 0-7 user
ports and ext0,1,2 declared in rtl8367c driver, although no model I
know does use ext2.

Reviewed-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>