Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <8012a613-91ea-466e-f77e-6fc5453724f5@ieee.org>
Date:   Tue, 7 Jun 2022 14:06:14 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] staging: greybus: audio: fix loop cursor use after
 iteration
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Jared Kangas <kangas.jd@gmail.com>
Cc:     vaibhav.sr@gmail.com, mgreer@animalcreek.com, elder@kernel.org,
        gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
        johan@kernel.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev
References: <20220605231806.720085-1-kangas.jd@gmail.com>
 <20220606130626.GX2146@kadam> <Yp9/kqBUzpArfPdn@fedora>
 <20220607183921.GQ2168@kadam>
From:   Alex Elder <elder@ieee.org>
In-Reply-To: <20220607183921.GQ2168@kadam>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/7/22 1:39 PM, Dan Carpenter wrote:
> On Tue, Jun 07, 2022 at 09:40:50AM -0700, Jared Kangas wrote:
>> Thanks for catching that! Is there anything I need to do to add the
>> 'Fixes:' tag to the patch? From my understanding, adding tags is done by
>> a maintainer later on, but I'm new to the patch submission process so I
>> want to make sure I'm not missing anything.
> 
> No, it's up to the person sending the patch to add the fixes tag.

And FYI, "git blame" can be your friend here.

     git blame drivers/staging/greybus/audio_helper.c

It looks like commit 510e340efe0cbd is a possible
candidate, but I'll leave it up to you to determine
that.

					-Alex

> regards,
> dan carpenter
>