Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <e020f60d-218c-8e47-5863-23dcb55452f2@nvidia.com>
Date:   Tue, 7 Jun 2022 15:22:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v6 06/10] kbuild: check static EXPORT_SYMBOL* by script
 instead of modpost
Content-Language: en-US
To:     Masahiro Yamada <masahiroy@kernel.org>,
        linux-kbuild@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        Peter Zijlstra <peterz@infradead.org>,
        linux-modules@vger.kernel.org, llvm@lists.linux.dev,
        Ard Biesheuvel <ardb@kernel.org>,
        Sami Tolvanen <samitolvanen@google.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
References: <20220513113930.10488-1-masahiroy@kernel.org>
 <20220513113930.10488-7-masahiroy@kernel.org>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20220513113930.10488-7-masahiroy@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0RKRmg5MWF2a1EzbUVrYlp5UGxlWEJWWjE3MXVBWmlZUkRDVTVjdXJsNFZr?=
 =?utf-8?B?MnNCK2FLMUlUbVhPMFZRZ3JUNjkrQTRUQ0x4SUhHZFg0My9EbVVydUZkTUNR?=
 =?utf-8?B?ZFFxWEJEK1lSZW8waCtRWnVkNzZrZjdjU3lwdVNHUGZvRmdoMnFRUEVGMXhs?=
 =?utf-8?B?NVExcnVUSFlvRldMaHErWFcyZmtnUXZCVjlTWTNFaVNIVkZhZnNreXVERE5R?=
 =?utf-8?B?YWZlNnRtSHpHNkFHbDdYR0tuanNVb2U0VkpZbHJCeWlyRTc3WVorNUV5UWY5?=
 =?utf-8?B?QlQzN3hvNGdMVFdiaGJSMC9lTHFHRDgrMUxjZ0MzMEt4NENOLzAzazRRSW16?=
 =?utf-8?B?bDM1U2FGS0d2blpJbVE5dzJEZEVqUmVoQXBIUW9UZnZTUVRsRzdncEc0cGZa?=
 =?utf-8?B?V3JzdWV1TFU3b3dDdDJHU04xaDRpMHRtZ3lLWmlEdXZpYUgxN25vYXJRQlBX?=
 =?utf-8?B?QzRVRzBSUG9HSWF6dUp4NTNsVzZEOHVhdEpzOGlFUkR5aFYvaUJPd1lpSnF3?=
 =?utf-8?B?S2dWZ1VEUG53L3RuMkRoY1BNb3g4aGhUUkZvVlFEbGg1THczaXFxZU9BZmVH?=
 =?utf-8?B?UjAwVnJ4cFgvcUlyTzR2eTNoeUV1NXA0RDVOOTdacW1oQXM0MndMZDM4RWh6?=
 =?utf-8?B?blcySk0xRzF4eWx3WEFEQlNOVWl2OW8rS2htM3hFY2ZDTnhBemR0cjFCRDQx?=
 =?utf-8?B?OVpIQ0lVVTJFTWx5UVhFMUVJTDRsUnprS3NScWpkNk9hRFZ0TzlmanhpLzlh?=
 =?utf-8?B?Y21Rdzk1OUFJZDBrd1VyaC9XYkhYdE44Ry80a0JScW0xNzN3UlhKRWV3dXds?=
 =?utf-8?B?WEpvdWNOWTlueVMzRXZOYXpVOVFrOGtDcTU1dElaeExBaUdOWmJjMVp5dUtS?=
 =?utf-8?B?WVVQRmhDN284em1zNkM0V3VaczNyWXBMYWVVN3cxd0trVHBPd05vR0NCRnZy?=
 =?utf-8?B?NzZBNFVzcW5xMkpla2QvcVk3STVvUnd1NVc2SXVhUVhxcUltcklsbjdFM1Fy?=
 =?utf-8?B?Qis0V1Ezc0FHSFdLV2tnMEVCeXJXTWcySjVvL1hoUG9uY3FKTWgzMFExejc2?=
 =?utf-8?B?dkE5cWF0ZERHR0U4V0pUcE9sTFJEWEhQaXZwS3l6SEdVZHFXVjFHM1dvQVdI?=
 =?utf-8?B?RlVQM2UvN1p0VTcyZ1EybTVUb3lzYmhDL3o1Q1lQZGxvUHdSRDE5VjNJdkJK?=
 =?utf-8?B?ZzF1UlZyUnRCazhYemNjM3J5SHh1dXkyQUVIMFgyRDhFazg2VnJFMkxmNDdT?=
 =?utf-8?B?eExpeUtWNnFjMGcycm8wUTRieHVDZm9odzg1MzliUE1KRFVkVTc2UTRZOFZ6?=
 =?utf-8?B?MlZ4QVVFU0VjcWFJcTUrWEs2VWFOaC9YRmFPNkhhblJYMnhUd0w4VHFlNzc3?=
 =?utf-8?B?ZmZzYUZvT3VqZFlpS3dCRlJXSXgvL3JCYy96Z1M5ZG5nUlFwWlZwU20wNzRs?=
 =?utf-8?B?R3JqSmNzajhYYXh6Mm9kbVRROTJHU0Y1S0lpSUtUL25seC9QZzdSMk5hMWZ1?=
 =?utf-8?B?UkV3VG1tR1Z2VlZlTVkyenJBV1B6OHE5dEhzSHZBdEpFTyt0dkM4bXBOcE5I?=
 =?utf-8?B?N1dFS0huS25xTTBiMEdzdGc1UEkrOSszYUF1b2lRV1RXbHZGa1lmMTdVYjd4?=
 =?utf-8?B?NWthYThza0dIaGRpUVR2dWJ6Q08vejVoMjI5b1Q4WWJsNUxlaWlDWWs5dVdC?=
 =?utf-8?B?MWcvVktUWFBVWEwvT2IwcitLUnI4T3liLzhObXE1cFpGejZHdFBiM1I3emRh?=
 =?utf-8?B?YVRhSitWbFRJOVRQRVJtdm5wMmdud2FYZ3UrWmEwaHI0bThpZzRocWIxN0Ew?=
 =?utf-8?B?bSt0WU9YcFd0RFZpc1VGNDlKdXZCYXBQNHpCb3RqTHkxNW5hdTBiVlpXNVNl?=
 =?utf-8?B?WjJ6MVZtOEExdmkyS0czY2c0NitTWkpXRjNRdzBGLzJsVTB0SFpBZmthcXV6?=
 =?utf-8?B?UXpzcFF5QTFtZmlySXc1eGhxTnYwdVFINTdCTGtlZ0J3S3VNdU5ZbUYzcFIz?=
 =?utf-8?B?aTN0WHVleGEzaUp3anRFcUY2V0xubEN5OHpxdW1kM2hLYWNpNjB4Uy9pbGxT?=
 =?utf-8?B?U2twOUZrQTJmK0NqT3MxbmcxUE5kcktjdXBDSE14VW9SZHlySFB6bnY5UWwv?=
 =?utf-8?B?NUNTYnRaTEx5cVNPc256OFI0bXhRR3RRM1dXNWtmM2dYU3haQU1BYVY0ejBK?=
 =?utf-8?B?aWxvcldOTXdXYVpkNUV1MTl1elpQR0preUVOalZGdmF2YUZKRXFmekRJazlm?=
 =?utf-8?B?SnQ3bEY2Q3ZEQ05NTExRYzZnMEdKSFRjSWtRSG9yU3ZISWhYSjE0V29SMXlm?=
 =?utf-8?B?OCtWMm10MUt2NVR0YVJ4aThNa1pPVWNjUE5IVTNpbnBVNzJFNHJia3RxVTdJ?=
 =?utf-8?Q?b5crClZ33OO2QanY=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 161eef67-fc17-4f76-1045-08da4891267f
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 14:22:28.2946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P0wbqyMhqZNWWy7g8NJh4r9ONt32YNpyNeLIi5ZzdT/KoU2fQ0q0JEsTPxrECZASa2dvbByrMWnfbX/OQT2LuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3893
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 13/05/2022 12:39, Masahiro Yamada wrote:
> The 'static' specifier and EXPORT_SYMBOL() are an odd combination.
> 
> Commit 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL*
> functions") tried to detect it, but this check has false negatives.
> 
> Here is the sample code.
> 
>    Makefile:
> 
>      obj-y += foo1.o foo2.o
> 
>    foo1.c:
> 
>      #include <linux/export.h>
>      static void foo(void) {}
>      EXPORT_SYMBOL(foo);
> 
>    foo2.c:
> 
>      void foo(void) {}
> 
> foo1.c exports the static symbol 'foo', but modpost cannot catch it
> because it is fooled by foo2.c, which has a global symbol with the
> same name.
> 
> s->is_static is cleared if a global symbol with the same name is found
> somewhere, but EXPORT_SYMBOL() and the global symbol do not necessarily
> belong to the same compilation unit.
> 
> This check should be done per compilation unit, but I do not know how
> to do it in modpost. modpost runs against vmlinux.o or modules, which
> merges multiple objects, then forgets their origin.
> 
> It is true modpost gets access to the lists of all the member objects
> (.vmlinux.objs and *.mod), but modpost cannot parse individual objects
> because they may not be ELF but LLVM IR when CONFIG_LTO_CLANG=y.
> 
> Add a simple bash script to parse the output from ${NM}. This works for
> CONFIG_LTO_CLANG=y because llvm-nm can dump symbols of LLVM IR files.
> 
> Revert 15bfc2348d54.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nathan Chancellor <nathan@kernel.org>


One some older build machines this is causing some builds (ARM/ARM64)
to fail ...

/dvs/git/dirty/git-master_l4t-upstream/kernel/scripts/check-local-export: line 54: wait: pid 48433 is not a child of this shell
/dvs/git/dirty/git-master_l4t-upstream/kernel/scripts/Makefile.build:250: recipe for target 'scripts/mod/empty.o' failed
make[2]: *** [scripts/mod/empty.o] Error 127
make[2]: *** Deleting file 'scripts/mod/empty.o'
make[2]: *** Waiting for unfinished jobs....
/dvs/git/dirty/git-master_l4t-upstream/kernel/Makefile:1285: recipe for target 'prepare0' failed
make[1]: *** [prepare0] Error 2
make[1]: Leaving directory '/dvs/git/dirty/git-master_l4t-upstream/artifacts/linux/arm64-defconfig-jetson'
Makefile:228: recipe for target '__sub-make' failed
make: *** [__sub-make] Error 2

Any ideas?

Thanks
Jon

-- 
nvpublic