Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 7 Jun 2022 17:39:45 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
Cc:     Ian Abbott <abbotti@mev.co.uk>,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        Johan Hovold <johan@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/1] comedi: ni_usb6501: fix transfer-buffer overflows
Message-ID: <Yp9xQeXfsJ+sP4WB@kroah.com>
References: <20220607134720.6343-1-xiaohuizhang@ruc.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220607134720.6343-1-xiaohuizhang@ruc.edu.cn>
Precedence: bulk

On Tue, Jun 07, 2022 at 09:47:20PM +0800, Xiaohui Zhang wrote:
> Similar to the handling of vmk80xx_alloc_usb_buffers in commit
> a23461c47482("comedi: vmk80xx: fix transfer-buffer overflows"),
> we thought a patch might be needed here as well.
> 
> The driver uses endpoint-sized USB transfer buffers but up until
> recently had no sanity checks on the sizes.
> 
> ---
> 
> Fix the typo in the last bit of the old patch which use the wrong
> endpoint to determine the size for usb_tx_buf.
> 
> Signed-off-by: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
> ---

Please read the documentation links I sent you that say how to properly
document this.

Please do so and then you can submit a v3.

thanks,

greg k-h