Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756234AbXETLjD (ORCPT ); Sun, 20 May 2007 07:39:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755179AbXETLiy (ORCPT ); Sun, 20 May 2007 07:38:54 -0400 Received: from ug-out-1314.google.com ([66.249.92.169]:42180 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755178AbXETLix (ORCPT ); Sun, 20 May 2007 07:38:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=E8Ek5kQn/mj7x3+X8Cumq1umBHYxgnS2w0nR/KXM9Hs5wlOhCpdHQt8kxLKz/fdqAz69sg/DqoLhscWWbA4CNmH/kK6oWouECPF3v0sNnOw727p5SJT/WjZZE+XHg8Rg8s9o9bVZeDKgutcK+J6YwhBC2V45cSYecWhMaWQ03Iw= Message-ID: Date: Sun, 20 May 2007 17:08:52 +0530 From: "Satyam Sharma" To: "Stefan Richter" Subject: Re: RFC: kconfig select warnings bogus? Cc: "Andrew Morton" , "Sam Ravnborg" , LKML , "Roman Zippel" , "Kumar Gala" , "Simon Horman" , "Adrian Bunk" In-Reply-To: <4650074A.6000307@s5r6.in-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070519151523.GA26724@uranus.ravnborg.org> <20070519110944.2a52061e.akpm@linux-foundation.org> <464F9A7B.1030708@s5r6.in-berlin.de> <4650074A.6000307@s5r6.in-berlin.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 26 On 5/20/07, Stefan Richter wrote: > Satyam Sharma wrote: > > You'll learn about the "default .. if .." Kconfig idiom after you try > > this, > > I have seen these in the rest of the patch which I didn't quote. > > However you fix it --- don't remove "depends on" or "select". You can > interchange them, but not remove them, unless there wasn't a dependency > to begin with. They _can_ be removed, with absolutely no build failures at all, because of the "default y if ..." on the dependency that is defined in some arch/.../Kconfig. In fact the whole _idea_ is to remove any mention of the arch-specific dependency from arch-agnostic stuff in drivers/.../Kconfig's (be it "depends" or "select") so as not to generate those "unknown symbols" warnings that would come on other archs. Hence, the normal practice to use the "default y if ..." idiom (for "bool" helper code like the original examples on this thread) in arch/.../Kconfig files. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/