Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757355AbXETL6O (ORCPT ); Sun, 20 May 2007 07:58:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755097AbXETL6A (ORCPT ); Sun, 20 May 2007 07:58:00 -0400 Received: from ug-out-1314.google.com ([66.249.92.174]:56635 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755066AbXETL57 (ORCPT ); Sun, 20 May 2007 07:57:59 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=q18SFGLKe5r6o3Dh4RQJHzVLjTTrJt7UOoDCNlILXzcWUwVTe+R53GeNWLhBG0vrMBV7jPS2babcE2PiOOFvLbBfz7n5kXLiMccnAU5LMW3Z2O5iD11I4mCsMd/LPVQyH/Wrvm7qAQsDWeEAOfMn9yo64ex4Zct7UYrasAz8jYE= Message-ID: Date: Sun, 20 May 2007 17:27:58 +0530 From: "Satyam Sharma" To: "Stefan Richter" Subject: Re: RFC: kconfig select warnings bogus? Cc: "Andrew Morton" , "Sam Ravnborg" , LKML , "Roman Zippel" , "Kumar Gala" , "Simon Horman" , "Adrian Bunk" In-Reply-To: <46503542.50300@s5r6.in-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070519151523.GA26724@uranus.ravnborg.org> <20070519110944.2a52061e.akpm@linux-foundation.org> <464F9A7B.1030708@s5r6.in-berlin.de> <4650074A.6000307@s5r6.in-berlin.de> <46503542.50300@s5r6.in-berlin.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1676 Lines: 40 On 5/20/07, Stefan Richter wrote: > Satyam Sharma wrote: > > On 5/20/07, Stefan Richter wrote: > >> However you fix it --- don't remove "depends on" or "select". You can > >> interchange them, but not remove them, unless there wasn't a dependency > >> to begin with. > > > > They _can_ be removed, with absolutely no build failures at all, because > > of the "default y if ..." on the dependency that is defined in some > > arch/.../Kconfig. > > You are right, they can be removed, and the Kconfig files can be turned > into an unmaintainable mess. > > A requires B > > Maintainable. > > B serves A > > Logically equivalent, yet unmaintainable. Well, whether it is readable / maintainable is subjective and hence debatable. I was only answering your *completely misplaced and incorrect* original comment against the patch where you claimed that the patch was "totally wrong" because of the way it removed the "select" ... etc ... And remember, like I said already, the whole _idea_ is such arch- specific helper code be not mentioned from arch-agnostic Kconfig files. You may not like it, but this is the standard / most common way such cases are handled for tons of other cases in arch/.... Which is why Adrian's way of solving this (shifting all such arch-specific helper symbols also to drivers/... and then using depends on select on it) is not viable. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/