Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 7 Jun 2022 16:21:00 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Jiri Slaby <jslaby@suse.cz>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/36] tty/vt: consolemap: define UNI_* macros for
 constants
In-Reply-To: <20220607104946.18710-3-jslaby@suse.cz>
Message-ID: <59e0ae93-c7b-2087-75f8-4da0de918250@linux.intel.com>
References: <20220607104946.18710-1-jslaby@suse.cz> <20220607104946.18710-3-jslaby@suse.cz>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1534695395-1654607902=:1622"
Content-ID: <7e28987a-6395-d443-4367-a4e8891c480@linux.intel.com>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1534695395-1654607902=:1622
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Content-ID: <de645f70-e7af-dfeb-4ac2-646eea40a368@linux.intel.com>

On Tue, 7 Jun 2022, Jiri Slaby wrote:

> The code uses constants for sizes of dictionary substructures on many
> places. Define 3 macros and use them in the code, so that loop bounds,
> local variables and the dictionary always match. (And the loop bounds
> are obvious now too.)
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>

Reviewed-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>

> -			for (k = 0; k < 64; k++) {
> +			for (k = 0; k < UNI_ROW_GLYPHS; k++) {
>  				glyph = p2[k];
>  				if (glyph >= 0 && glyph < MAX_GLYPH
>  					       && q[glyph] < 32)

Probably unrelated to this change but what's that < 32? It seems to appear 
twice related to the inverse mapping (and you didn't end up naming it).


-- 
 i.
--8323329-1534695395-1654607902=:1622--