Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 7 Jun 2022 12:52:25 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        michael@amarulasolutions.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 11/13] can: slcan: add ethtool support to reset
 adapter errors
Message-ID: <20220607105225.xw33w32en7fd4vmh@pengutronix.de>
References: <20220607094752.1029295-1-dario.binacchi@amarulasolutions.com>
 <20220607094752.1029295-12-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iuaxzdq6irzebpfy"
Content-Disposition: inline
In-Reply-To: <20220607094752.1029295-12-dario.binacchi@amarulasolutions.com>
Precedence: bulk


--iuaxzdq6irzebpfy
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 07.06.2022 11:47:50, Dario Binacchi wrote:
> This patch adds a private flag to the slcan driver to switch the
> "err-rst-on-open" setting on and off.
>=20
> "err-rst-on-open" on  - Reset error states on opening command
>=20
> "err-rst-on-open" off - Don't reset error states on opening command
>                         (default)
>=20
> The setting can only be changed if the interface is down:
>=20
>     ip link set dev can0 down
>     ethtool --set-priv-flags can0 err-rst-on-open {off|on}
>     ip link set dev can0 up
>=20
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

I'm a big fan of bringing the device into a well known good state during
ifup. What would be the reasons/use cases to not reset the device?

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--iuaxzdq6irzebpfy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKfLeYACgkQrX5LkNig
012aSQf/XyECEKk/TwoC1qpcrU6CZDRxLCJs8tO38g6r8u6mGtbNQEwIhtUIYwPZ
4bPJ+V4a3GaJ1QyY0uAQUZVvrJLergmgsAw+xXg4wYHFzwSG46M7gxtAFiHP7JE8
rT9u+6IYs7gnhDsp24FpscyE/B7PJ+DaJRvqXe6WO74cPR9hIYlNHgNX5NElUWcz
IT1rFeGbnYpuW481T0PELKvF7sx8QnGSMPFtrij3vxaNOE9iI5ikMaTiotYM3u2S
9rG8i3HKyN8xpGt5WXr4mDei4ZQrxSFrUdGQnl6bsDve27+3os44YrXWeFF/+Opa
T9DFUSWf/2gt3UrSmFM/Kfb6qvxL0Q==
=PcMi
-----END PGP SIGNATURE-----

--iuaxzdq6irzebpfy--