Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 7 Jun 2022 13:01:26 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     duoming@zju.edu.cn
Cc:     linux-staging@lists.linux.dev, davem@davemloft.net,
        kuba@kernel.org, alexander.deucher@amd.com, broonie@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: Fix sleep in atomic context bug in
 dm_fsync_timer_callback
Message-ID: <Yp8wBoXH+k9k7Jg+@kroah.com>
References: <20220520061541.14785-1-duoming@zju.edu.cn>
 <Yp2T7xSM8YX7lX0/@kroah.com>
 <6c014f68.52c9b.18137daddd9.Coremail.duoming@zju.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6c014f68.52c9b.18137daddd9.Coremail.duoming@zju.edu.cn>
Precedence: bulk

On Mon, Jun 06, 2022 at 03:11:39PM +0800, duoming@zju.edu.cn wrote:
> Hello,
> 
> On Mon, 6 Jun 2022 07:43:11 +0200 greg k-h wrote:
> 
> > On Fri, May 20, 2022 at 02:15:41PM +0800, Duoming Zhou wrote:
> > > There are sleep in atomic context bugs when dm_fsync_timer_callback is
> > > executing. The root cause is that the memory allocation functions with
> > > GFP_KERNEL parameter are called in dm_fsync_timer_callback which is a
> > > timer handler. The call paths that could trigger bugs are shown below:
> > > 
> > >     (interrupt context)
> > > dm_fsync_timer_callback
> > >   write_nic_byte
> > >     kzalloc(sizeof(data), GFP_KERNEL); //may sleep
> > >   write_nic_dword
> > >     kzalloc(sizeof(data), GFP_KERNEL); //may sleep
> > > 
> > > This patch changes allocation mode from GFP_KERNEL to GFP_ATOMIC
> > > in order to prevent atomic context sleeping. The GFP_ATOMIC flag
> > > makes memory allocation operation could be used in atomic context.
> > > 
> > > Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
> > 
> > What commit id does this fix?
> 
> Thanks for your time and reply! 
> The commit id this patch fix is 8fc8598e61f6 ("Staging: Added Realtek rtl8192u driver to staging").
>  
> > And how did you find this issue?  Did you run the code to verify it
> > still works properly?
> 
> I find this issue by writing codeql query. I am trying to use usb raw-gadget to simulate
> rtl8192u card in order to test this code.
> 
> What`s more, I found the usb_control_msg() with GFP_NOIO parameter in write_nic_byte() 
> and write_nic_dword() may also sleep. So I think use the delayed queue to replace timer
> is better. 

Please explain all of this in the changelog text when you resend this.

thanks,

greg k-h