Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220606134553.2919693-1-alvin@pqrs.dk> <20220606134553.2919693-5-alvin@pqrs.dk>
In-Reply-To: <20220606134553.2919693-5-alvin@pqrs.dk>
From:   Luiz Angelo Daros de Luca <luizluca@gmail.com>
Date:   Tue, 7 Jun 2022 11:28:32 -0300
Message-ID: <CAJq09z6Gs9Ltah0mb0hnLORf+_jmLokqU9Oi63JpD8=-LZLpMg@mail.gmail.com>
Subject: Re: [PATCH net-next 4/5] net: dsa: realtek: rtl8365mb: remove
 learn_limit_max private data member
To:     =?UTF-8?Q?Alvin_=C5=A0ipraga?= <alvin@pqrs.dk>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        =?UTF-8?Q?Alvin_=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Russell King <linux@armlinux.org.uk>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> The variable is just assigned the value of a macro, so it can be
> removed.

The 10-ports devices do use a different value.

    <10 ports
    /* MAX LUT Address Number */
   2112,

    10-ports
    /* MAX LUT Address Number 4096 + 64*/
   4160,

I guess learn_limit_max could be migrated to the new
rtl8365mb_chip_info structure.

Regards,

Luiz