Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2142505iof; Tue, 7 Jun 2022 21:10:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypQ8C4YM7P74qQ1yuQgXr9TCx648idZNrwgSmdWAkdN8928NinUW0rYe4+AXV4m+3Jil2N X-Received: by 2002:a17:902:cf05:b0:156:9d:ca01 with SMTP id i5-20020a170902cf0500b00156009dca01mr31917630plg.111.1654661406755; Tue, 07 Jun 2022 21:10:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654661406; cv=none; d=google.com; s=arc-20160816; b=DLP+gbVnxgT4/ftoJt3DZgKC3TrsKe0kd7WilaY1mFec0fpLImw4bbiPTDWO4GRV8Z Z+kQYXXh+bSxPw18aOTybzMzqV5Mo1DzY8fc+Vd7ugxuufS6H/hfyhZrWGXJFUaS7zPy ZME7KazMoaJJQhf7Zh+PZfK7MeM/puGwbULZqD3JVdSgtZKR2qB/c55vEZgCqTDbPfKB Od2VjsHsvo3L0oyb4XnH3N9WIZh8QgsdGelpztUXejQX1TfdNV2VE7TftJlFsq4FX4lb OG5jbwsEoOctyWzrELybyh0awbhT8mjN121KGtMa1jIQ+kSIJLzNmIS5OZZk1odL4Xc6 v7Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sHC8t0/2usqVnySTkkglLVUiJYCoybvBxEmtT+Jhcbk=; b=0ay2nm4PMasGUakYBgXRXahyjiA3zEB8SYg0u0w0nM7m+dB988/CYP+mlaSbIOGeDG ik3cS4A0lFLI9e0h66WiLFV5wWUJanzasHnwbWkNpYd21G4vlhl5MuD29a3cDzzGw5tk iVzMS92tu93/z/PdmaawB0lmwn7ItBMeT+uBKwrMk0SuFBy3kZTFqVHINWA+PUZLVfVo cYzPvhUlOGl4znYSQWsPrsCI9Gv94/Gt5SIAkr5/sqeGBJYLQEuP6JLz/BNct1IO0YGz 210s6Y5SBSU5OvNXKZCka08+SwF3PgzRya8Slbgs8JicIMhEuzXBs6m/GzcXDlU+S0hT HZIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BND6vij9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id c11-20020a056a000acb00b0051b2c6fe811si27895051pfl.90.2022.06.07.21.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 21:10:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=BND6vij9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 31FBA21FBE3; Tue, 7 Jun 2022 20:41:35 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358319AbiFGUXD (ORCPT + 99 others); Tue, 7 Jun 2022 16:23:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356585AbiFGTbs (ORCPT ); Tue, 7 Jun 2022 15:31:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CE951A65F0; Tue, 7 Jun 2022 11:12:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7424060920; Tue, 7 Jun 2022 18:12:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CDB3C385A2; Tue, 7 Jun 2022 18:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654625554; bh=gam7VJRU5tQrQ47mhnmERO7Bdx+TDXwHG5e3vtQwqLQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BND6vij9ON04xrMRbkxddk8bDBdKlhyJt9Uhub2Kt/jb1z7rjLat2FNFgm8moWH23 YfTP2JUty4MY+xd9Oiy5DK5EgBxItUq3PksrMdCOEeHVP5+hdcYqdJ7bLIXFTbZ9vE PMhPp5iAYaoPIObDHL+bfOv8uI7blz0YLrgxea3I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Haowen Bai , Kalle Valo , Sasha Levin Subject: [PATCH 5.17 060/772] ipw2x00: Fix potential NULL dereference in libipw_xmit() Date: Tue, 7 Jun 2022 18:54:12 +0200 Message-Id: <20220607164950.809103592@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164948.980838585@linuxfoundation.org> References: <20220607164948.980838585@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haowen Bai [ Upstream commit e8366bbabe1d207cf7c5b11ae50e223ae6fc278b ] crypt and crypt->ops could be null, so we need to checking null before dereference Signed-off-by: Haowen Bai Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/1648797055-25730-1-git-send-email-baihaowen@meizu.com Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/ipw2x00/libipw_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/ipw2x00/libipw_tx.c b/drivers/net/wireless/intel/ipw2x00/libipw_tx.c index 36d1e6b2568d..4aec1fce1ae2 100644 --- a/drivers/net/wireless/intel/ipw2x00/libipw_tx.c +++ b/drivers/net/wireless/intel/ipw2x00/libipw_tx.c @@ -383,7 +383,7 @@ netdev_tx_t libipw_xmit(struct sk_buff *skb, struct net_device *dev) /* Each fragment may need to have room for encryption * pre/postfix */ - if (host_encrypt) + if (host_encrypt && crypt && crypt->ops) bytes_per_frag -= crypt->ops->extra_mpdu_prefix_len + crypt->ops->extra_mpdu_postfix_len; -- 2.35.1