Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2142883iof; Tue, 7 Jun 2022 21:10:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxq8u+imxlkKEt4/J4icI3gridfIjYKGm1BWShsXPV9GP90QRMALhtXmQPUFMEl4sv5vxNH X-Received: by 2002:a17:902:e5d2:b0:164:1958:c858 with SMTP id u18-20020a170902e5d200b001641958c858mr32600080plf.62.1654661454806; Tue, 07 Jun 2022 21:10:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654661454; cv=none; d=google.com; s=arc-20160816; b=CesPSM5I3wTMgxeVUYHbXn4qigR4d0NyK0qZZGI2ZBM3YCjhM0LJuI4OWnKkiyL3QZ 8e1wLnXC8AskSK08sdVt9eTzLZ6L8xnGCaeMZxM9hyK1pMA2J9etZL4d3Kvv+92pn/x2 kMqLc6d79cy8WiAArH55JE1Jc36dBII9WWoM3Fwe7mpt86MNI5ZZFcQeD/95o41+yC2/ D4SpIehr4Hb04oODmgNrES4BHaA2w7HcMFiXSpayX5AXMaY3Y/yuwkkZPgHzd8+i+r+p w2ejTn4bSkwqkK8h7jOooUfsfxbN36Q5bM8qGsDIN5TIpyUgsa1Kz4GUZ0Hk9iJqIwFt mHeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6skCEfKDqRqGqBX1lbA9dr/1KW2nsqBWRIx6igx2opo=; b=pR1uY5V8UAcjPwVcKZciF28AeAR/RNc4lJl5/Zruqj9MbrESJm0f06UGbXJImH43aa jxedi9HfEitCKsf97nLS8GkdvB+aHzemIo8EhavKqzyOppmZF7oP1+B/68zIbdVbZUQa crkjzhaqbe92pMIAzDiEj+cUsMTUV0rH2pdTr40hVYE5DG49x3AB2K7VpE6e/ieUaPHX vCzuGQG4Ysv4ClKQRlbgQDDidcR5raa65Zr34M4N2hTtDMFm3UQa+pU3/xS86tku4AZ+ n55ZsAyAntP9AicWWOxhE3v7jljY2K7FNtVSMhqAB6JLdcegpYHNokfnbYghWZCMAnWu wL+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=P+GMxdkb; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id lw9-20020a17090b180900b001e675c62e3fsi13945062pjb.71.2022.06.07.21.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 21:10:54 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=P+GMxdkb; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6419827C26A; Tue, 7 Jun 2022 20:42:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359644AbiFGUpf (ORCPT + 99 others); Tue, 7 Jun 2022 16:45:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357976AbiFGTmi (ORCPT ); Tue, 7 Jun 2022 15:42:38 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 561A6237E5; Tue, 7 Jun 2022 11:17:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 284B7CE244F; Tue, 7 Jun 2022 18:17:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EAC0C385A5; Tue, 7 Jun 2022 18:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654625857; bh=63KEk9VLTggDHYa7uCWhw1ThCahBRf68liu0x9+Y4Q8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P+GMxdkbz3GpjzryiT3HlD6chHB4lXcKUXLBVIR/9OLN71hFqMpbnx0lXvlO0/zyx pKKTQ8VrrlDfUG1S95Q+tDEt9qrnztxdrPgKnZPbTt2o0OIvznTIOREMzZUc8VXQLH 1bneB3FmizpRtPLW0vtRCVYgU6kA7U57d9bGiDoA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Patrice Chotard , eberhard.stoll@kontron.de, Mark Brown , Sasha Levin Subject: [PATCH 5.17 129/772] spi: stm32-qspi: Fix wait_cmd timeout in APM mode Date: Tue, 7 Jun 2022 18:55:21 +0200 Message-Id: <20220607164952.845897605@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164948.980838585@linuxfoundation.org> References: <20220607164948.980838585@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Patrice Chotard [ Upstream commit d83d89ea68b4726700fa87b22db075e4217e691c ] In APM mode, TCF and TEF flags are not set. To avoid timeout in stm32_qspi_wait_cmd(), don't check if TCF/TEF are set. Signed-off-by: Patrice Chotard Reported-by: eberhard.stoll@kontron.de Link: https://lore.kernel.org/r/20220511074644.558874-2-patrice.chotard@foss.st.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-stm32-qspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index ffdc55f87e82..dd38cb8ffbc2 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -308,7 +308,8 @@ static int stm32_qspi_wait_cmd(struct stm32_qspi *qspi, if (!op->data.nbytes) goto wait_nobusy; - if (readl_relaxed(qspi->io_base + QSPI_SR) & SR_TCF) + if ((readl_relaxed(qspi->io_base + QSPI_SR) & SR_TCF) || + qspi->fmode == CCR_FMODE_APM) goto out; reinit_completion(&qspi->data_completion); -- 2.35.1