Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <485c0c0b-a3a7-0b7c-5264-7d00c01de032@suse.com>
Date:   Tue, 7 Jun 2022 17:00:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
From:   Jan Beulich <jbeulich@suse.com>
Subject: [PATCH] x86: drop bogus "cc" clobber from __try_cmpxchg_user_asm()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVZIQ2U5NTdvQkQ1MGdJeStzZmxpN2ZQQWtIQXRnaGJxQk5QaDl0TER5UTlJ?=
 =?utf-8?B?TU5uaUVEdWpidjhqOThJbU9jdFd3d0VCaDhIY2YwRm5QRmZRcFJOUERqanJI?=
 =?utf-8?B?Ym54TVUxb3pYZ3JuQjByelpWdEN2dFp5VG9NYWJiUEhEL2gxSHdDT3g2RkIr?=
 =?utf-8?B?UjJYYVlITjRMelhoTlZkTmJuNlRGcktMOW93bU9LNXNFQVpkWFpJSmIrOWp5?=
 =?utf-8?B?N3NPN2hNeEpyYis0RHJNMmZqdE42OTZTSHdLR05TaHdodFp3QUpuTG55YXVU?=
 =?utf-8?B?L1JQTVZPSlZnU1R6c1JiTmtuN0JFamdtNFB0Wk5XbUFmM0cyRWRWOCtkZFV3?=
 =?utf-8?B?VmZvWmRlTmljc1NQTlFETzJMYWs3TVhDSmtsdjQ4OXJxN2syRUVCRy96TUNN?=
 =?utf-8?B?WmMxQlBHbEVSSk5kMVlSOWZhUHdFWDV3cEFCRHgxNmRCSkpQdUJZWk93b29Z?=
 =?utf-8?B?WWVCT1pEUVVFSnFLQStBVDBjVFNRWklrT3QzcGg3VThPa2FHMDlWR2JsYlVD?=
 =?utf-8?B?eW9jbEFXV3gxc3FHejIvamJOTjVUUkM3VkJYNnB2T2lmQ0NMRno5YTlKRDk2?=
 =?utf-8?B?dDQ1MnBUc0RMWXRRdDh6aE9WUDlpRjVDTFgzemdoVzlDclZIbFg5OUlrY1ly?=
 =?utf-8?B?ak5QeXloek4wZ1B6cDk2YXFHTi9iTWFvckZaL1hQMFkxcEU2azFWd09hbUZv?=
 =?utf-8?B?b3R5VG5RSitwRm81Y1VQcEtlSkFGNmd4cWVINUxsWHpNSGNlV2pzem1ldlZN?=
 =?utf-8?B?OHhHWktCeWJhOGl0YkxMMTZZYXhBWVNsbnpOS0VNTUsyN2ZTZ2xOK0JpZEN2?=
 =?utf-8?B?Z2RNUXp1NEVIbTZhQ3VnYVY2T1B4LzlJYWVOdkREQzVXZ3M3ZE9aa21UcUVM?=
 =?utf-8?B?eis4V1RQcnJoa0dnREc3RVJwdm1rcFc1K09pL3A1TFI1T0xibU02aWlTL1JD?=
 =?utf-8?B?Q2h3NERHbTg5VSsrQ3hIKzgvREdXYUM2Z1B1cTRkemlubFFHYzBsdWxuOTU4?=
 =?utf-8?B?em1ZT09TeEtzeFFVWGJ2UDN0cXBCTElwcHdHbnJWclBKQ1ZmZVNFRWg3TzZN?=
 =?utf-8?B?WWtSVGo2NTJpM09OM1h0WlczNWpKYTF0eEU1QW1PdlNicGQ2ai9GWXZKY2lP?=
 =?utf-8?B?STkvclliUnBXejdYV3RGOGZvZ0RzUElBc25ybVNkVVlWNTJ4LzVLVWd4UkVY?=
 =?utf-8?B?S2FyV1o4TFZ5eXlyRUJjZDVveHpOOEp0c1JPK202SUFRWWNFRGN0bEM4cGlQ?=
 =?utf-8?B?bHE2Z3VzditoQkRZejVSdzdjRUUxYUJEV1VaT0hUY21Ed1dJb0xoQlJrMXFY?=
 =?utf-8?B?RDZ2SDlxTlBqTlBaUCtITDNHUkROaG1La3RWVmpJUXo3UE9HSXVCTmxvSWhl?=
 =?utf-8?B?Q0JtNm0ySjM3VUhOalJLeUk0M0luNFBZZXdYNTkrOC9HckxoMVZwaDYxZzlh?=
 =?utf-8?B?SXM5eDBITWxtY2pYS1BmeExvdGdVbkpMWUsrelNtK1Z6S1pMZ1pjVk1XeFJ4?=
 =?utf-8?B?Sk1QLzFUekFOVGtOSzFVQi9PbVRxL2Nkd1JyTXVQczYzeUZ4TUZxVDJwenpB?=
 =?utf-8?B?OHhXVFNDbnpRUy92T0NrWGU5Y3FXU1Rjb3Z6V1E5UEliNTluTGN5ayt5T2tN?=
 =?utf-8?B?anhXSHhWVHdQRjFRSEREN3FKWEh6YUpNcDhORU1vdHVDcEE1aVBGaFJPKzJo?=
 =?utf-8?B?em1pYXgwOWlZRXpoSnczQUhmRGMxZ3k5SXNUS2dBS2gwL2pWM1pRR3NRWEtl?=
 =?utf-8?B?MWtYK2FFak8vMFJRdEk0ZzVLMjdLRC95SnBxTnRWN2tvbkQ0eHFjSHJUS0I3?=
 =?utf-8?B?Mk5uYzVQc3FtTmQxK3Y4dHdoMmMzMlJnV0U1andYYmEvZUFnR0tDek56VkdN?=
 =?utf-8?B?U1hHL0toSUhYUm01V05SbWp6dktNMHJidjJOL0ZXUkkzbCtLemtYdzZyZXE4?=
 =?utf-8?B?a3VlTW8wdGRGL1FrQ2luckNaMVI2enN5akNMbXhoaW0vM0ZFRVBrT3dqd2pG?=
 =?utf-8?B?R05IS1J5UmdaN00ySDZTZE4vaWVmUHpNZUVSYzhmSDNiMUZZQzltWmc2Tkhz?=
 =?utf-8?B?YkdaT2dUbTVTajQ1R1lKbitsSGIxUGRaeE92ZVVzTkVmenorSUh3WEpYSGRi?=
 =?utf-8?B?eVptZFpEQ2RoRW5sdFBld1JiM1B5RUtSZCsxTXRNSFM5VG95MHQ1endqYzlU?=
 =?utf-8?B?eVhrSXZ0MytKUXdqUmtGcHg1TWRCbHJWOVl0UXR2ZzRTYTQwU1lmNUl2aG12?=
 =?utf-8?B?TS85b3A0YmdqNXdWeHc0TG5mY2tMK2JnaEVzQXlDdWJNbmUwVWtWT2NFOWRO?=
 =?utf-8?B?ZEhGNnhlZU9Dd2NoRmhFck5wSlBrZHhFUm8rSG84c3R6cUJFR3NJdz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9edcdee9-a93e-441b-5047-08da48968590
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 15:00:55.0874
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: boE7Njlf7ANfoRkOLu97UCtDwNzODKZxBGGxktq5035RfrSIP2HfB0DBOHeCbC2e5QB0UBVedrXxBPqvbHKZJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7878
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As noted (and fixed) a couple of times in the past, "=@cc<cond>" outputs
and clobbering of "cc" don't work well together. The compiler appears to
mean to reject such, but doesn't - in its upstream form - quite manage
to yet for "cc". Furthermore two similar macros don't clobber "cc", and
clobbering "cc" is pointless in asm()-s for x86 anyway - the compiler
always assumes status flags to be clobbered there.

Fixes: 989b5db215a2 ("x86/uaccess: Implement macros for CMPXCHG on user addresses")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
The change I continue to carry locally actually allows specifying that
"cc" is _not_ clobbered; it only happens to improve detection of bad
situations like the one here.

--- a/arch/x86/include/asm/uaccess.h
+++ b/arch/x86/include/asm/uaccess.h
@@ -439,7 +439,7 @@ do {									\
 		       [ptr] "+m" (*_ptr),				\
 		       [old] "+a" (__old)				\
 		     : [new] ltype (__new)				\
-		     : "memory", "cc");					\
+		     : "memory");					\
 	if (unlikely(__err))						\
 		goto label;						\
 	if (unlikely(!success))						\