Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2145952iof; Tue, 7 Jun 2022 21:17:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1mc2xk8rgUtjrsSKceX/IrPs2MRQIgjQzUKQxLbHUH8NtcFLguKHcTWkLJhayxC8+U/WD X-Received: by 2002:a17:90a:974b:b0:1ea:2bd3:b6f5 with SMTP id i11-20020a17090a974b00b001ea2bd3b6f5mr3802119pjw.196.1654661820678; Tue, 07 Jun 2022 21:17:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654661820; cv=none; d=google.com; s=arc-20160816; b=MX/o2M53B3GBjudOpcoqYAMJerTcNfRG7LYKsTOSvLh6VDNYOOaxvxSfoxACYSprti HcEpu6vcJuNqXjy92J9wKTAiU9V2J7l54m4C5z4i7orChHKr1rAArdLDYmnpPGto0Jbr U/VEacDAsxzEeynDqtcH/ANtpHkCQpdGYBjTxw0ANoOBRPwx1ooloGY3Dr1jSR8X6dvq h5PNhYe5Rny8DxyulfXScdJoIanr1oTV5aQf3+sfotja33GjKBXNEZFzJfRc1KctJ+jI tk24J5ZR4mIsVeHAmZTQQEbrCdCi221QqI5i82WL9BC1tDfifqR3ZQqDNs5w1XO/hFQD C3xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=czmPlok22mj6t1sYjMk0hy1Un1RCJhBWCBiCp4R5d7A=; b=yBVJCJrczPCAaRa0Y2Y2XRQlm2uzmfV2iaDJ4D2LxBMgp2tdKtY01covxMzo837q4L COwei5ls8sjgV32wqczHAyQnRJhLryGT/2Nwzk0IkFoim/rmroyPEYdBOGBUuknqblWA 1Hcs6veSc4FRiHFKCt21VyAnK/Z7hd4EA79g9xSVfOMdUc6iOd2Rze2rAVUIZz/7Eb7K xicl1thGN/hB7LyD8Ch6t/qQcfNJQhp2SNOTjS9yFlQktIkneNlKMnCzpBKpRi1ZpupH vmjm6GOwkl0xSDSv4+1k206Dymf+gXEhB6KjKXNOUEvTLX7ngHPh+fF8G/8qZawYtHtB HgYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RMWpFeT9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id j6-20020a654306000000b003fa5e1daaa7si25022020pgq.197.2022.06.07.21.17.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 21:17:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RMWpFeT9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6CD213004CD; Tue, 7 Jun 2022 20:48:14 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229789AbiFFVdA (ORCPT + 99 others); Mon, 6 Jun 2022 17:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233631AbiFFVdA (ORCPT ); Mon, 6 Jun 2022 17:33:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1641A3B55A; Mon, 6 Jun 2022 14:32:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AE681B81BD4; Mon, 6 Jun 2022 21:32:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64E7BC3411F; Mon, 6 Jun 2022 21:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654551176; bh=9wW78eqRW+8CIx9i+7pjI5Ws5cP7kXj2HXPttlOJSKc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RMWpFeT9OKyPVlCjkLE8sQqVvrGS9lAvEGB5ykHS/u9A0m3KmmSLZItcDha4xJ1C+ 3hhrCaMy5J97Ljvx5P6VVtutPFC3nbeNQirTqlPLUJ/a6Vy/6APybG6ZyWJc1O4WGR noIYGahmi9bTrlusRMdgayYJVyizyAov/9JELVMG6Zg24UqnBNM0okdy5e1Ab7mP2t AZHrbEL5mSWbbg7ZANrKSmliJJx4SBrTc7P3TgJTxh5F72PCSSFjUIRz8+CdOlO6rL A8EW7zpRPz6H0EnTrIe6qyWK02jG8mfbcDefQeHZdq8xU+JiexAs62rs9aezZzdkbV kQtIQpSUTw/Hw== Received: by mail-ua1-f51.google.com with SMTP id d18so387720uaw.2; Mon, 06 Jun 2022 14:32:56 -0700 (PDT) X-Gm-Message-State: AOAM5313Noy2X3bppCZvgGuqJwGTKQsDn3iNzF8innqWqjj7LVSC/FIn 9XJgrgm5WniqFVI49h+7MQ1QxelwuwOXzTmKSw== X-Received: by 2002:ab0:5a95:0:b0:369:1a3f:358c with SMTP id w21-20020ab05a95000000b003691a3f358cmr24079388uae.63.1654551175305; Mon, 06 Jun 2022 14:32:55 -0700 (PDT) MIME-Version: 1.0 References: <20220605055123.59127-1-linmq006@gmail.com> In-Reply-To: <20220605055123.59127-1-linmq006@gmail.com> From: Rob Herring Date: Mon, 6 Jun 2022 16:32:43 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] PCI: microchip: Fix refcount leak in mc_pcie_init_irq_domains To: Miaoqian Lin Cc: Daire McNamara , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , PCI , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 5, 2022 at 12:51 AM Miaoqian Lin wrote: > > of_get_next_child() returns a node pointer with refcount incremented, > we should use of_node_put() on it when not need anymore. > This function only call of_node_put() in normal path, > missing it in some error paths. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 6f15a9c9f941 ("PCI: microchip: Add Microchip PolarFire PCIe controller driver") > Signed-off-by: Miaoqian Lin > --- > drivers/pci/controller/pcie-microchip-host.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Rob Herring