Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2148422iof; Tue, 7 Jun 2022 21:21:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpzk6ep4MLawP4IZG+emEq+l32ScySUGl8ewKsPOoQn+xc3RfH8lCryG8TWbw0AerhquOs X-Received: by 2002:a17:903:41d1:b0:166:3c6:f055 with SMTP id u17-20020a17090341d100b0016603c6f055mr32477380ple.112.1654662107686; Tue, 07 Jun 2022 21:21:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654662107; cv=none; d=google.com; s=arc-20160816; b=P/9tG6ffshPeS62HczXyx3Ss6BnKISK3RgW/1Bp0maS/4ifmtjalZooifGnFx3xruk HPFGHOl9c6E7Y77Vl7TrX9lWIQUwThjMwn9Npb60eHoIqUMwda5zeTdoDA38v6Y5fRUG dp6biuZsjSVmq+md3Frq3mWNOA+N8Gz2k1m5q8PF+9Ax9MbxGtpf6vIeDHUzEfPgkugF QdBY2ILYrjz1mbln6pO/QbOy/zSh/tGgOW0wpl3lorHGVqr8Yp9kg79ERjiyzUG0ZC76 Ru3J1iZbFXyV5GXCZCk65wOFi80n6/7v3C2bPQgLk6CAryZKrse9YKAM0RZ35Gu1v+Z6 Kv4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wvz8n0/6cUH+ZJgGkR/M61YbRX3xL3LS9rSWs5rMvnM=; b=D5doSNE1KwGr2MUJQtCKH5osK/PefHQBbaR7e1/TcopiC/pL6TxWRZ52zD1VnVWE9j Rr88zjsCaXpK3PSBCLMWhG0vbjWPxJ42fkQxcYyzjGRw8Qs/7oulKDfH30W9V0Dl1FN0 qSF5iWEnW3hBHBxM41KQ40RGYK1EWeNkLv8MPcWsjyb+AKYb1I8fBGYpTRs2tSzdsRhU lZQkbvsH1WLGp6oj0PdMAbJQMbfPKJh9bb9Y4pV9M7NA3n8UYp613Li8Pb9necwcEZyz zOExIfSxreTMtJpjlvvhBdMsBBeWyk3FQL5XfKiaQl50Zu2GBRB4N+Tkev3aueoAIc2d Aydw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tsU3S1Np; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id mi4-20020a17090b4b4400b001e881637bd7si10651880pjb.77.2022.06.07.21.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 21:21:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tsU3S1Np; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BC973422412; Tue, 7 Jun 2022 20:53:38 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243709AbiFGR6i (ORCPT + 99 others); Tue, 7 Jun 2022 13:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347270AbiFGRig (ORCPT ); Tue, 7 Jun 2022 13:38:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5200330569; Tue, 7 Jun 2022 10:33:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 57E16B822B4; Tue, 7 Jun 2022 17:32:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEEE6C34115; Tue, 7 Jun 2022 17:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654623161; bh=QaBLpXvVZZrFl1X5v6hzQGyuNtnzNjh2StDhRAR2WBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tsU3S1NpgAeUZdvv/GhanE3SCX59IJ0RG9u/cHml+yYYVlkEKS7FYuFOu8Py2Kz9o MgL2v3aNpz0NHa6NmzMr/oyYjKSDgy0Skw+qmKVis4aAhn2IocumiXpVW5spwEdF5Z 7fgceKHtFTRutXvF35uPVtEk/YIKsmP/+nm03E/I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Linus Walleij , Sasha Levin Subject: [PATCH 5.10 290/452] pinctrl: mvebu: Fix irq_of_parse_and_map() return value Date: Tue, 7 Jun 2022 19:02:27 +0200 Message-Id: <20220607164917.192273312@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164908.521895282@linuxfoundation.org> References: <20220607164908.521895282@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 71bc7cf3be65bab441e03667cf215c557712976c ] The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO. Fixes: 2f227605394b ("pinctrl: armada-37xx: Add irqchip support") Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20220422105339.78810-1-krzysztof.kozlowski@linaro.org Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 5cb018f98800..85a0052bb0e6 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -781,7 +781,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev, for (i = 0; i < nr_irq_parent; i++) { int irq = irq_of_parse_and_map(np, i); - if (irq < 0) + if (!irq) continue; girq->parents[i] = irq; } -- 2.35.1