Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 7 Jun 2022 14:30:39 +0200
From:   Lukasz Majewski <lukma@denx.de>
To:     Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
        Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 1/3] ASoC: wm8940: Remove warning when no plat data
Message-ID: <20220607143039.01cdff80@ktm>
In-Reply-To: <Yp4wzS0aLEo5werI@sirena.org.uk>
References: <20220606154441.20848-1-lukma@denx.de>
        <Yp4iGvGFD9jo4WUP@sirena.org.uk>
        <20220606181731.04b6f771@ktm>
        <Yp4wzS0aLEo5werI@sirena.org.uk>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/ZDrERQF4JXuQvzusRTtzOG5"; protocol="application/pgp-signature"
Precedence: bulk

--Sig_/ZDrERQF4JXuQvzusRTtzOG5
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Mark,

> On Mon, Jun 06, 2022 at 06:17:31PM +0200, Lukasz Majewski wrote:
> > > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote: =20
>=20
> > > > The lack of platform data in the contemporary Linux
> > > > shall not be the reason to display warnings to the
> > > > kernel logs. =20
>=20
> > > Given that the device requires configuration and doesn't appear to
> > > have any other firmware interface support that's rather a strong
> > > statement... =20
>=20
> > My point is that - similar codec - wm8974 don't display such
> > warnings. (this code was not updated/refactored for a quite long
> > time). =20
>=20
> Perhaps those drivers are buggy, or those devices lack this specific
> configuration that's being adjusted?  The changelog should at least
> address why the driver was warning about configuration being required
> but it's safe to ignore that.

With v4.4 from which I forward port those changes only the PXA
'stargate2' mach is using this codec.

In this version there is no reference to 'vroi'.

With newest Linux - there is no reference to this codec (even to any
DTS file), so we can assume that from at least v4.4 there is no
reference to platform data for it.


I guess that one can provide the 'vroi' information via DTS nowadays if
required.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/ZDrERQF4JXuQvzusRTtzOG5
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmKfRO8ACgkQAR8vZIA0
zr2zMQf/b77NogZ5Gk9SrUZ7tnUgQBCQNfeSGNsiTK0z1uHlS6CIcEhTidUfr60h
NOnlUDG+lYYN6Fyo7qzXVUlQ0ROOXKkvGCeFIwB6yQCb7y0/uZ9s+SozoXq7DjkT
CN4wA92r6g9B1J1rhcnUH4phPlazhDQifwDPQFxJ0ww7ODCER5tUUqzhE6Gsoplc
YUG48vjXxzg6Sy5pSKJHwcL7YIGwUTui1e82PVu+IZndAnP+4izheE3joAfhn14k
Q/F8qnOHH+FbF8FYKenJybVAZxE6JVXA4jY5RYknN65AwHYE8sAnyh2Zp1ckJQf4
vmu+7wnj4eNUbwGMgDyCyzOsO23I7w==
=g3pk
-----END PGP SIGNATURE-----

--Sig_/ZDrERQF4JXuQvzusRTtzOG5--