Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 7 Jun 2022 14:15:33 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Tianfei Zhang <tianfei.zhang@intel.com>
Cc:     gregkh@linuxfoundation.org, rafael@kernel.org,
        linux-kernel@vger.kernel.org, hao.wu@intel.com, trix@redhat.com,
        yilun.xu@intel.com, russell.h.weight@intel.com,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>
Subject: Re: [PATCH v1] regmap: add generic indirect regmap support
Message-ID: <Yp9PdZn2Xu/oqiA8@sirena.org.uk>
References: <20220607013755.594554-1-tianfei.zhang@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Ud64OMVfP0hcRpQO"
Content-Disposition: inline
In-Reply-To: <20220607013755.594554-1-tianfei.zhang@intel.com>
Precedence: bulk


--Ud64OMVfP0hcRpQO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 06, 2022 at 09:37:55PM -0400, Tianfei Zhang wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>=20
> This patch adds support for regmap APIs that are intended to be used by
> the drivers of some devices which support generic indirect register acces=
s,
> for example PMCI (Platform Management Control Interface) device, HSSI
> (High Speed Serial Interface) device in FPGA.

What is "generic indirect register access"?  I'm not clear what this is
intended to support...

> +static int indirect_bus_clr_cmd(struct indirect_ctx *ctx)
> +{
> +	unsigned int cmd;
> +	int ret;
> +
> +	writel(0, ctx->base + INDIRECT_CMD_OFF);
> +	ret =3D readl_poll_timeout((ctx->base + INDIRECT_CMD_OFF), cmd,
> +				 (!cmd), INDIRECT_INT_US, INDIRECT_TIMEOUT_US);
> +	if (ret)
> +		dev_err(ctx->dev, "%s timed out on clearing cmd 0x%xn", __func__, cmd);

=2E..and this doesn't look particularly generic, it looks like it's for
some particular controller/bridge?

--Ud64OMVfP0hcRpQO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKfT3UACgkQJNaLcl1U
h9BidQf+IkIlquE0S6OoW3iH1zUA7CLH2gTDIlN6mRlexJIF+FySYkuqKFEklPWb
ZLgnPTZACw1QW9kMna9oNRltHCL/6/M8d+tnD+wYAwHBWWCcX86td4i/iini59ad
dL1eTnaSR5C6uba0ArBuCsr4zHI0aCQgIKJTf2lJPt+aaAcGPdOEanLQjBkDh0vu
GLQHpsVvV1myPuSMXZncUIeK0x7f6PXBESELsnxcB/RdnnD2+Rrtq+KhwQ8mCZmM
l+y/Hnyts/aMsKzQ1L7YHdgAXT3Lx85j+QdQNWuNjnh4oJSDqlJiAxTqUhQy2Lne
vNJRYefW76T3bVHcG7izYWwEXq8Bfw==
=CMt6
-----END PGP SIGNATURE-----

--Ud64OMVfP0hcRpQO--