Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2156732iof; Tue, 7 Jun 2022 21:39:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFcGJIywamN1xfRFpo6tSxuVg8f+a+xcqUFAzm7g6CP7Wtu90jyMiyVTu3Pf/7Whe6nNwm X-Received: by 2002:a17:90b:1d08:b0:1e3:2a4f:6935 with SMTP id on8-20020a17090b1d0800b001e32a4f6935mr48581572pjb.174.1654663164424; Tue, 07 Jun 2022 21:39:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654663164; cv=none; d=google.com; s=arc-20160816; b=wMoJpNHoEnZuUParbua//betK0K0XhNVAOccrgYsF427+ysgf2J+S3io6g7d603iNi 6kFFpMJPJyAd5ey+DJ8id7gVpdvzBPZJzUrTof2js0ELVDAdXpiguUmW2Mtv8DFnPj76 Yu1YT0KLSo/4y1ssDfWN42DUZgD4G6+uD3+DCkqaZV0NGi3VIp4dSEBiBD88RsyPNxco juf9rAq6A7thNyBZPH0RgwIrP3qdKGerooHNbT1wO9OlgKUEa8laWfqwe/L7HJ5wdmZ4 BUZmZnwNpX7C7SBOKILiTkNk9ikLksMBSjQkvGedU0N5oXhdJUqVOzcFcn1SGBMdNaGd 8g7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3KKOmxSOfKHj3Xd+NqMIvw/0/srTRIWnSazj3cAllPc=; b=QUibmksRuAy+rcqwCJ/xa1TyHM5+ebs81WZPYYaOgSJVJvU8+4oK1gUAtiYR7Gg0e5 rQKOm5JGrjZ1Ts9qr3r/xJxWcm5rOkY5gcYCQlQOnxv+CVSvdIgJK77a3wLYx+vJxxhZ T+greVj5adtNbDR2rpthBdrB/p31f5/e6X6B8L+hUH5FzITuSgUk5MDhdd892cGp4TkL kWZlbHlj6OCKvulptlXtpPPYZroRyVC24LYeLmksP47lvORH6dpPFPm/zOtDwQ9K2+oX G44v1ybHbDQfJwMmAxAc4/MfKihDtP/L3xrQmdxeruCF91skUaY/BpVp9Ntp97nyVQ0k Pfvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ekONIaXu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id j5-20020aa78005000000b005183163dfa7si17676664pfi.267.2022.06.07.21.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 21:39:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ekONIaXu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9451B27CD68; Tue, 7 Jun 2022 21:07:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379374AbiFGV7Z (ORCPT + 99 others); Tue, 7 Jun 2022 17:59:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358000AbiFGVCd (ORCPT ); Tue, 7 Jun 2022 17:02:33 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC0661257A7; Tue, 7 Jun 2022 11:48:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1F563B81FE1; Tue, 7 Jun 2022 18:48:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30BABC385A5; Tue, 7 Jun 2022 18:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654627696; bh=EI6kyMEv2r+oMfMB12oZQKomnwfH3xTNuKb7+f/Swr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ekONIaXuFNaElP+cfhCHcEhQKgSdPzFJ3mVCA5Qef9mfOL3dHhId+Xf6j1yIzd+Qr HE8msErNZS7DH1RyPXTbquxQJCVc0XPQNCnV1ARolW2I5kXzl4/09N1NHOZ7bWsI83 gKrZG+ljHmcnnA5+rCk9rFILwEafIyufsQ64M/YU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikolay Borisov , Andrii Nakryiko , Sasha Levin Subject: [PATCH 5.18 059/879] selftests/bpf: Fix vfs_link kprobe definition Date: Tue, 7 Jun 2022 18:52:57 +0200 Message-Id: <20220607165004.404373852@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607165002.659942637@linuxfoundation.org> References: <20220607165002.659942637@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nikolay Borisov [ Upstream commit e299bcd4d16ff86f46c48df1062c8aae0eca1ed8 ] Since commit 6521f8917082 ("namei: prepare for idmapped mounts") vfs_link's prototype was changed, the kprobe definition in profiler selftest in turn wasn't updated. The result is that all argument after the first are now stored in different registers. This means that self-test has been broken ever since. Fix it by updating the kprobe definition accordingly. Signed-off-by: Nikolay Borisov Signed-off-by: Andrii Nakryiko Link: https://lore.kernel.org/bpf/20220331140949.1410056-1-nborisov@suse.com Signed-off-by: Sasha Levin --- tools/testing/selftests/bpf/progs/profiler.inc.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/profiler.inc.h b/tools/testing/selftests/bpf/progs/profiler.inc.h index 4896fdf816f7..92331053dba3 100644 --- a/tools/testing/selftests/bpf/progs/profiler.inc.h +++ b/tools/testing/selftests/bpf/progs/profiler.inc.h @@ -826,8 +826,9 @@ int kprobe_ret__do_filp_open(struct pt_regs* ctx) SEC("kprobe/vfs_link") int BPF_KPROBE(kprobe__vfs_link, - struct dentry* old_dentry, struct inode* dir, - struct dentry* new_dentry, struct inode** delegated_inode) + struct dentry* old_dentry, struct user_namespace *mnt_userns, + struct inode* dir, struct dentry* new_dentry, + struct inode** delegated_inode) { struct bpf_func_stats_ctx stats_ctx; bpf_stats_enter(&stats_ctx, profiler_bpf_vfs_link); -- 2.35.1