Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2157436iof; Tue, 7 Jun 2022 21:40:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybCnFSB8jWjJ/XkhOmkyC0zBQzuMVC81zmLF/DPAVHm+WWUTynEovGPwn0+9kwInoer94f X-Received: by 2002:a05:6a00:170c:b0:51b:f057:85c2 with SMTP id h12-20020a056a00170c00b0051bf05785c2mr22033810pfc.18.1654663242207; Tue, 07 Jun 2022 21:40:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654663242; cv=none; d=google.com; s=arc-20160816; b=tfON/PV+waPyv2B0mDGN2v4AwMKF9cW775BD5zbbGk/Hr2eFFsBcrCNy8Bp5w9m+nC 7y0zfeN69y8lHJweVSxUgI8O9XqNqn7EspEA16XB+YwXkmZhRtiSTLytjZ9c8paFaOGp cynj7H1jBNWoLeDiiv2uHJwPhWeCujWScgi9YvDrwLaSRidCW4NnCqAWf4bnIF1vniMK HfVag5wTNGYKJWRHLsZDOppiDOliwGNy8XT5OaIMaK63gKGKmWH8w41RI2qEpceAz+ex i+NVkzIPfZfR5oVJumRweGpAFi+3idmkk4gKsN7ZQoR/8MZ+kvITWeQ47cr8W0RA1Q7K V1Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xRFNcFTscC+Eiiwa6lUqF6rio77eYndWtZPJm3DXQJY=; b=OI4Xh9kiYoXaLXesAJ7zkTAAV3IXQM8anwlEq3xJd7FEEyGOcS0gpXRxkURmA2JlXv MHJNfaKJ4nJ+jkn7BMT7cn5U42KibSPsva0YA2+O0MH2Z2wjgYecBy0U8462/ApHRZky j+l7ThLq+dbwq9WviUJNqBnrYG5iYQexRxA8jy8iDPN8TKcPvCK3auLwZXLL+70BYi9J igEZr5KOPMxoxeqoGd3eAYc2RL0AlvPTLZDW4AA5OM7t8HsCLfDnnTFmkIJBQVxLVTmy mW+ulphSt6LsijzuGYyLIoT+O+RaUM36I8BKw4RRtrcQs4ABbO8YEdNCWaYfI2dC3KN3 sVnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y6IAs6tP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id l12-20020a056a00140c00b0051c395582d3si5740285pfu.186.2022.06.07.21.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 21:40:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y6IAs6tP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E36B569730; Tue, 7 Jun 2022 21:07:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376536AbiFGUgh (ORCPT + 99 others); Tue, 7 Jun 2022 16:36:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357818AbiFGTmX (ORCPT ); Tue, 7 Jun 2022 15:42:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F70C15A77B; Tue, 7 Jun 2022 11:16:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D89DDB81FE1; Tue, 7 Jun 2022 18:16:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40439C385A2; Tue, 7 Jun 2022 18:16:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654625785; bh=G45LbsVsKGm/veOUJ8V2dv8LiU/3OcCdVZgGMgEciHw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y6IAs6tPuZ5I+c88warX+YnMZ40+wo+IEwqGZF1QMkv8gTUArQo7vPyauHH6hgX6/ 6bnuigwc4sR5aLMohI3C0qTj+JfcqxiRw/7LcqG+3eeNUfzNPtrIzCGeX83PDlFfFj y09AXdX4SMMU5IVi5nPJARHkRAbnC/39VjvCCav4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.17 143/772] media: ccs-core.c: fix failure to call clk_disable_unprepare Date: Tue, 7 Jun 2022 18:55:35 +0200 Message-Id: <20220607164953.257614766@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164948.980838585@linuxfoundation.org> References: <20220607164948.980838585@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil [ Upstream commit eca89cf60b040ee2cae693ea72a0364284f3084c ] Fixes smatch warning: drivers/media/i2c/ccs/ccs-core.c:1676 ccs_power_on() warn: 'sensor->ext_clk' from clk_prepare_enable() not released on lines: 1606. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ccs/ccs-core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c index 9158d3ce45c0..1649b7a9ff72 100644 --- a/drivers/media/i2c/ccs/ccs-core.c +++ b/drivers/media/i2c/ccs/ccs-core.c @@ -1603,8 +1603,11 @@ static int ccs_power_on(struct device *dev) usleep_range(1000, 2000); } while (--retry); - if (!reset) - return -EIO; + if (!reset) { + dev_err(dev, "software reset failed\n"); + rval = -EIO; + goto out_cci_addr_fail; + } } if (sensor->hwcfg.i2c_addr_alt) { -- 2.35.1