Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 7 Jun 2022 10:43:09 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Marc Zyngier <maz@kernel.org>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        linux-gpio@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: nuvoton: wpcm450: Convert irqchip to
 IRQCHIP_IMMUTABLE
Message-ID: <Yp8Pne/qdf0U7xri@latitude>
References: <20220606214301.2061467-1-j.neuschaefer@gmx.net>
 <87r141ylry.wl-maz@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tIVOFWmxb8CcysXs"
Content-Disposition: inline
In-Reply-To: <87r141ylry.wl-maz@kernel.org>
Precedence: bulk


--tIVOFWmxb8CcysXs
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 07, 2022 at 08:29:05AM +0100, Marc Zyngier wrote:
> On Mon, 06 Jun 2022 22:43:00 +0100,
> Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net> wrote:
> >=20
> > Commit 6c846d026d490 ("gpio: Don't fiddle with irqchips marked as
> > immutable") added a warning for irqchips that are not marked with
> > IRQCHIP_IMMUTABLE.
> >=20
> > Convert the pinctrl-wpcm450 driver to an immutable irqchip.
> >=20
> > Signed-off-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
> > ---
> >  drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctr=
l/nuvoton/pinctrl-wpcm450.c
> > index 0dbeb91f0bf27..cff784a7ce4d7 100644
> > --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> > +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> > @@ -293,6 +293,8 @@ static const struct irq_chip wpcm450_gpio_irqchip =
=3D {
> >  	.irq_unmask =3D wpcm450_gpio_irq_unmask,
> >  	.irq_mask =3D wpcm450_gpio_irq_mask,
> >  	.irq_set_type =3D wpcm450_gpio_set_irq_type,
> > +	.flags =3D IRQCHIP_IMMUTABLE,
> > +	GPIOCHIP_IRQ_RESOURCE_HELPERS,
> >  };
> >=20
> >  static void wpcm450_gpio_irqhandler(struct irq_desc *desc)
> > @@ -1068,9 +1070,8 @@ static int wpcm450_gpio_register(struct platform_=
device *pdev,
> >  		gpio->gc.fwnode =3D child;
> >  		gpio->gc.add_pin_ranges =3D wpcm450_gpio_add_pin_ranges;
> >=20
> > -		gpio->irqc =3D wpcm450_gpio_irqchip;
> >  		girq =3D &gpio->gc.irq;
> > -		girq->chip =3D &gpio->irqc;
> > +		gpio_irq_chip_set_chip(girq, &wpcm450_gpio_irqchip);
> >  		girq->parent_handler =3D wpcm450_gpio_irqhandler;
> >  		girq->parents =3D devm_kcalloc(dev, WPCM450_NUM_GPIO_IRQS,
> >  					     sizeof(*girq->parents), GFP_KERNEL);
>=20
> You are definitely missing the required updates to the mask/unmask
> methods, and you still have a now useless irq_chip structure in
> wpcm450_gpio.

Ah, true.

Thanks,
Jonathan

--tIVOFWmxb8CcysXs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmKfD3sACgkQCDBEmo7z
X9sTPhAAspZVvQlkB+ko+MYHXoQQFaAPYipqmfEKDTCkd7SvZ9kncD0DrLt4M5Hr
8C3HAO8oRTJbbV8paWIpG2mDwcKdFZ3laLzfXXiONOrmPJ05X+4vc9VzNhZ2r4qF
9MyKm9JPt0pTNGzO83fN8M9ObGXFUYq3LDPLMQKxxQxVXNjYn11n+TeMi4y2TmCX
iWQYmEIb8M6/jsdZ1woWC4XkvfaPbRji2hKMY/MtLsRk544zNHH6unMueLY30P7l
l7gLM+DpAS5Agw7PRGuYe7xuX5Wpxj15m5FqLeCYLGo8VcSNxy5KR3uXPWEASmmF
S7ecpGy1EJSrJzPCdw9r1tlLQ1aSikEjE/nkAPvWS8RHjQQam97IzKRwIHFBYtjE
DmPaKpVuuDrBbZ8ckdOd7Ys+8srzqd5fY4AAblYsNjownASqCVECX+XD3WI9By3q
OQ8LzqNOh83KD3kAUzI0gIzBssd2ldmLHlCFRejImWWzYnG2Kyhb8jiMwABnhR23
dU3+HZ1SwjXUeAb8ihnuyCDFQzUdrVUlo0sFHufU9kl0x+GVRL8JqyU2GXLNd5d1
G6yLDjAZm1N1L9+3ism0UvRym40ddaM2Uavs+AIYV1a0uahNUImIxk6C3c4byYHI
2FpcO6djb+ZKye8Wt/va9QFMTzf3W7EEoBpUxnHUXs5LJiwRkzU=
=Pv8v
-----END PGP SIGNATURE-----

--tIVOFWmxb8CcysXs--