Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2169154iof; Tue, 7 Jun 2022 22:02:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwL0Pjt+s7eQVWgDz9snZSPOZZfzD8SHO69HHfe6lclEOnP9vsRiETCPROVdAAD1LZaG0b2 X-Received: by 2002:a63:d151:0:b0:3fc:c299:a7a6 with SMTP id c17-20020a63d151000000b003fcc299a7a6mr28051282pgj.154.1654664559454; Tue, 07 Jun 2022 22:02:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654664559; cv=none; d=google.com; s=arc-20160816; b=So9aW7XU+Awm1BfEMxIW8aqA8DhVChLZSFcuSyxwD64YHl9Ig3aAjCTv8uWA/1T9Q8 5t6cI1e6cOVANrxZtA+Y/MzGtMHz3vKj7zhxWwpMmTnHeyeyzx+olObnEmC9JybmaZhI 1i2ggwOhRb0WTE47I2sT2/ANsF7uzrk/rCLzRX4YAM/CUfX95QKbCUpIUheM6eAi0IvN JyXUBjXCiLZ2s/xawLoiWvFaN3BHKMgzMgANaxKEpHxX1RxdHKwmCo68EoZmpdsLIycO 80v/H+fXH9LTK05HrwtPqGmC5Py1hOlXUVWmi6HCMNEEXPvkxVglFnZbNO1Jc85IdBn/ nhPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Mnxj45HaLy8CV0Or92srsLeEC6dwUEkSGSaFlbwc09w=; b=kbb5Jid45u0sJqRJuOHqsz9QGfxnYPmbLBslvHk/7IgauX4VndOL+I7oqdn+zpBxxW e/pm4f5U4z8SW8p6OWTvxGy1HthPNKcPvZjFxj38dzx6KLW/d4K3wBkGRQZh84r6xtio Ub7YHWc/yzpQLovd5dgQIoH+9E2tiQiwhc5ZAxQjoYB8lSs7iK3QjZ2cWlemFZqxCOHX LDSvVYXnSdhAQ3bxTUHqckeYKT/M5787ISmC5SYi5XdmE4fIdzOvQ439mT/+fy4/h7OK WWTONPLo6BtoRncX5uxwWU4mYmp+Nr0cL4AFHN+X2PuvxwjqED/a/lmtfs+DjeN+vr9u nrMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QdMRwQux; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u4-20020a63df04000000b003faefdcaec8si27341815pgg.816.2022.06.07.22.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 22:02:39 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QdMRwQux; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 88C12E528D; Tue, 7 Jun 2022 21:30:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348553AbiFGRlK (ORCPT + 99 others); Tue, 7 Jun 2022 13:41:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347639AbiFGRa4 (ORCPT ); Tue, 7 Jun 2022 13:30:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3788113B7B; Tue, 7 Jun 2022 10:27:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A0D49B80B66; Tue, 7 Jun 2022 17:27:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 188C1C385A5; Tue, 7 Jun 2022 17:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654622866; bh=ZAMveTWAi+AXmb7bx/BqPzHEUjQdOAW3YaWQ5M7ujiQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QdMRwQuxOrflSg4ON0by82Cv03XJiW5n8DHK8RKrielgntYKgLsimyrRfVm+e6ImH DgBvbh8IwOa00Zp/luINZ1NnH+h3OUi73/c7Me2wjln2GouJ8vz2a6rzFTZTTQeGAM I8RdAJn/qH77UmQlHp527KLGKsWstzlUAaT4hgSM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.10 212/452] media: exynos4-is: Change clk_disable to clk_disable_unprepare Date: Tue, 7 Jun 2022 19:01:09 +0200 Message-Id: <20220607164914.879757424@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164908.521895282@linuxfoundation.org> References: <20220607164908.521895282@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 9fadab72a6916c7507d7fedcd644859eef995078 ] The corresponding API for clk_prepare_enable is clk_disable_unprepare, other than clk_disable. Fix this by changing clk_disable to clk_disable_unprepare. Fixes: b4155d7d5b2c ("[media] exynos4-is: Ensure fimc-is clocks are not enabled until properly configured") Signed-off-by: Miaoqian Lin Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/exynos4-is/fimc-is.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c index d4b31b3c9282..dc2a144cd29b 100644 --- a/drivers/media/platform/exynos4-is/fimc-is.c +++ b/drivers/media/platform/exynos4-is/fimc-is.c @@ -140,7 +140,7 @@ static int fimc_is_enable_clocks(struct fimc_is *is) dev_err(&is->pdev->dev, "clock %s enable failed\n", fimc_is_clocks[i]); for (--i; i >= 0; i--) - clk_disable(is->clocks[i]); + clk_disable_unprepare(is->clocks[i]); return ret; } pr_debug("enabled clock: %s\n", fimc_is_clocks[i]); -- 2.35.1