Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <84819d83-7e96-be79-649e-e367592ca05a@oracle.com>
Date:   Tue, 7 Jun 2022 12:14:53 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 1/1] cxgbit_target: Reject immediate data underflow larger
 than SCSI transfer length
Content-Language: en-US
To:     Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Varun Prakash <varun@chelsio.com>, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220607143035.29541-1-xiaohuizhang@ruc.edu.cn>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20220607143035.29541-1-xiaohuizhang@ruc.edu.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTFORzkvampQUjZmeXRvbml1ajZDOUhFZXQ0cXFpS1dZS3R0ZzQ3aFRpbFFM?=
 =?utf-8?B?RUZyTk0rTHFlTTlNSGc5R0Z1bXBmY1lnQ21QKzBVWmtCRi9YampNUlptUldk?=
 =?utf-8?B?UlNDZkJIdnZrZjJyK3hDN2k4L3BZMXliTUZ6Mk9YTWZNM2l1RzZZbVB6N3lq?=
 =?utf-8?B?UEk5c291Q0dwNmFRYktoc2xlelY1ZFUxRitITXdEYmdES3ZTaU1lNVlZLzBk?=
 =?utf-8?B?VjQ1S283ZkZsZk45MEpYQm01emM5OU1XZUlIeFU5dC9udmVMN0twVzdXOWdh?=
 =?utf-8?B?MTA3NXQ2bG42dHBPV081Rm50bGxVL0tkQ2VHR0tpNnhlRHI4Y1duRjlrSTNI?=
 =?utf-8?B?UGovTnJRWHZha2trRmRSZFBGaEI5cXRLOG9vM09vOWN6VHQwUllITTQ3cnNi?=
 =?utf-8?B?Ny8xTVd0eVhMVFA4SXBBcUR1UjRZSGtvZE1iOVE1Mk1tZGpYRWFKQW5ZWjA4?=
 =?utf-8?B?cjRWMlJlQW9wdHY1YkM5NnYxSkRMWmxiVDMvYk1xeTBaSW9pNmpIUmFKMWZy?=
 =?utf-8?B?UlozOHd6MFNZaHI1dlR1dTVnaTNpRnJXR1MvMnlDSjlaUmovTlJlTUdVaFQ1?=
 =?utf-8?B?T0hRN0JiUHh2K1hFWmIvbFFxNGxDMTJvK2gxcHd6SUFIc1Q1RzZwZmdzaVlG?=
 =?utf-8?B?NHpMd2I5QUhoVGx5Z0QwbHZWVjliUVZJN3I1ejJGclg5N3BvdWRwdmF1TCtI?=
 =?utf-8?B?cFJsdjNxT0Z4bE9DUGRCcWVJL1FMYVkyYWs4OVcxdVRRZit0TXd4MHdBUUJu?=
 =?utf-8?B?SEpJeFVERGZMS2RyaFRPMGV0N0RCU25yNHZoeXlpalRjK21wenBCNC93cklC?=
 =?utf-8?B?ZlYydGZxQXowczZFcGdqMWlXaUxVNDVyK2taVDBvaVBnbTRSbGdPUzQyVGhK?=
 =?utf-8?B?OG9HUTM4bC90OXpVNGhHVENPczBTcHJxS252bU9NN0cxelpEbUZ2UDI5MFJo?=
 =?utf-8?B?YlhXOFZpUlhxQ240aHpKOHN0clBLOGtWcnRSTVJkYmc2QldjWWczZnlxMzFN?=
 =?utf-8?B?dXpBZHV6WXNtSzgwQmo5UFlaYVV3RjJKYUxoaDRqWWgzazExN2YvckJHVjlq?=
 =?utf-8?B?TnVhOUY1Ry9XbDA5VU8vUlEyaFF2MkRFd3Y5NWNWUVRQV2pBRWx1NHNkZXlv?=
 =?utf-8?B?S2JVYllYWlpXNlJYY29hK2hRcERWbTgrdHJhc1M3b0xESkdDY2hSL1dndGpB?=
 =?utf-8?B?YXdyL2VEam94QzgzRUNHbXJ4QUtuR0IzakpiRjk2WWxBcmtxbE9kTTVYVGxv?=
 =?utf-8?B?VE9HbENtZVZoc1B1dS91U25jdldMQ0d3WXdTYmdpV1ExNUp5M2ZycWhOa0Z6?=
 =?utf-8?B?N09GZmFlRFlwcVRSVGxncElvQkIvcS9acHNxc2pIVjMrMDZKZWhFcEVSMUpq?=
 =?utf-8?B?UE5QWkZUR1NmNHRQNjBTVno3NGxjNHBPRzhNUnAwWmxDbVA0L0owSDJXQnNo?=
 =?utf-8?B?S2RXcE9aYmxwd01oL1pFRVpiMUhYaTU0dmpHK2ppVjhIK0lVT1ZXSDgrUlJQ?=
 =?utf-8?B?YVpDQU1uOWtYcVY5S2xQbUFDSndGNlhWaWMxbktINVhLcTVzcWJ6YjNxcldk?=
 =?utf-8?B?bXdsOS9JQ3g5cXFaaEF2R3gyWU14OUZaTVgvcmFOU0xjZUwyQkZNblB1d0Fz?=
 =?utf-8?B?U1hVZGtBS0xTbVpwaEVWQUVlOTF2TVpNTlcvTXBsdlJycEFkQTVNZzE2cUpV?=
 =?utf-8?B?T3F4bVFXWkI0TTFuM0p2TzVRTnZhZ0N2V1Z2Qk1KTTdSd0daL1MxS1FTeUNE?=
 =?utf-8?B?VFZCdjJVcTZRL1dVcXJyTXM1emZUSG5TR0h2eUhKSktKYzJLTUJvYi85VnJZ?=
 =?utf-8?B?RmhUcXdDeDlVSGYyS2NqY1lnSU5SS0RpUDJ3emRCcWVseWxQdVgxQkJpSnpJ?=
 =?utf-8?B?VGdYUFFGTUlkelNrWlpTUmR1a2FsNUxXNkhUYlVya0RDa1Z1UTdjdHFUYlZv?=
 =?utf-8?B?Ukw2SkNKNXdCR0hNVnc1aEI0MG9FWlVXOW15RjNqTkZaSXAvbWc5Qlp4MFl0?=
 =?utf-8?B?QnEvZ3loZnovY2VQT0R2ZlRBRGI0NHk1NzlMYXl6NmQ3V2VTUDJ4L2I3WGVp?=
 =?utf-8?B?c1ZhY3RTcVo4Z3hZKytZZUlIYnhNNFVHbzJNb2ZmZGZvMTJmazJFekJPSFc1?=
 =?utf-8?B?aFpTVDhaeWdxM1VxWlZRYVV6ZmVjU244L2lINityWm14OWRKb3hRUzkwZk4r?=
 =?utf-8?B?VUFGTnUrSDY2ZkM4U0RvWmRVSUhxTmd0eXAyZDBJTFczZ3YwUXJySy9Zc3Js?=
 =?utf-8?B?VHc4NW5CalE1YUxMOWFJU0w3UHhsbnk2ZnBXTzFady80OHJqZHdOazlHNWRx?=
 =?utf-8?B?K3NEZDJNb01HeW4xY0lLQ3hCNWMyN2xZRDRNM3BvdHY3bWcyK3dwSkZhRW1Z?=
 =?utf-8?Q?M9gEsri87dZleIlM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37f434ea-cbf7-4005-dba2-08da48a93d6a
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2022 17:14:54.4526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MTkAluzxEbPP/jMHS+5GGdVzYIk5EXtKaDM0Bb7WlZGZpayqQoGLQgMQPZmN4X38obUUXctv5vKOgr5cI2j1jAeVBNras6XLA/Jwv6ciHbk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6038
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-07_07:2022-06-07,2022-06-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 adultscore=0
 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206070071
X-Proofpoint-GUID: YkuZ6NT2E-Ok2bySaftjjuqlPmD1Y6li
X-Proofpoint-ORIG-GUID: YkuZ6NT2E-Ok2bySaftjjuqlPmD1Y6li
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/7/22 9:30 AM, Xiaohui Zhang wrote:
> Similar to the handling of iscsit_get_immediate_data in commit abb85a9b512e
> ("iscsi-target: Reject immediate data underflow larger than SCSI transfer length"),
> we thought a patch might be needed here as well.
> 
> Signed-off-by: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
> ---
>  drivers/target/iscsi/cxgbit/cxgbit_target.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/target/iscsi/cxgbit/cxgbit_target.c b/drivers/target/iscsi/cxgbit/cxgbit_target.c
> index acfc39683c87..800bec4b1e88 100644
> --- a/drivers/target/iscsi/cxgbit/cxgbit_target.c
> +++ b/drivers/target/iscsi/cxgbit/cxgbit_target.c
> @@ -920,6 +920,18 @@ cxgbit_get_immediate_data(struct iscsit_cmd *cmd, struct iscsi_scsi_req *hdr,
>  	 */
>  	if (dump_payload)
>  		goto after_immediate_data;
> +	/*
> +	 * Check for underflow case where both EDTL and immediate data payload
> +	 * exceeds what is presented by CDB's TRANSFER LENGTH, and what has
> +	 * already been set in target_cmd_size_check() as se_cmd->data_length.
> +	 *
> +	 * For this special case, fail the command and dump the immediate data
> +	 * payload.
> +	 */
> +	if (cmd->first_burst_len > cmd->se_cmd.data_length) {
> +		cmd->sense_reason = TCM_INVALID_CDB_FIELD;
> +		goto after_immediate_data;
> +	}
>  

Do you need something like Bart's patch:

commit 4b3766ec0e1840f45bc9238e7e749922bdcb7016
Author: Bart Van Assche <bvanassche@acm.org>
Date:   Tue Apr 2 12:58:15 2019 -0700

    scsi: target/iscsi: Make sure PDU processing continues if parsing a command fails

with your patch or does cxgb avoid that somehow?