Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2174018iof; Tue, 7 Jun 2022 22:10:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytGYGYt953XrZQKni2dh5Q9Bf6vmi+NkbTSDeBW7yjzB4A2LzJoGwrh7anlhyi5x6bvSan X-Received: by 2002:a17:902:f54b:b0:163:e2fd:10a5 with SMTP id h11-20020a170902f54b00b00163e2fd10a5mr32871220plf.28.1654665039602; Tue, 07 Jun 2022 22:10:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654665039; cv=none; d=google.com; s=arc-20160816; b=c4tbJLmPVU7sJEO09Jmb7IbmcfdCWG03zHzC+Z9PwvDATC7pdKU/wjkkzEM1DoyOq8 QA3QTxiZgHXFXvi6wpnWFnFDUPzT0DhPI+rMAGPXoVljlNn8tHGm76Ef3c2luMDtMLSo DuPQuwPT33tMQ1nDClqw9kyE5IEIertp3ORKo4Vx8llgFmD83B6y52vxgn0E7Tw71QPf KmavQdDvPYUhPAuUEIkHf5UfOKyGxk0/eHUsz6CgjYja0W0LJzMPtBkjTHczTVyEeqUW +vT/B5MlKLFFjypiW2mhhwdvNPfYAUYXfrdu7O6OPKP9JJqiM8gI1ME0N2kN40R8Nrci 3TwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dnV0tCVWiLP8OFtx87GpOVY4KmMaphXQ9X8qd0UftTk=; b=sXE255C6/6JkuQWsHkVpE78mo+RomkeCey0jOXCsTugpJEfjJ01prtj3Uw2uWQdo0e K5WBln0mZl/4FWvDmuJIfh4RZ0l1fEF4JHDfaj9Rasdj86sejohyQxFx9uX8HbgDf7MP 5fr5OZHvU8RZhKvdfB9IWJcHy6SGDqbzHJG/OUeLaf4HgpSI0rS+8N6LjhN54Ctervs+ ooWP49JbYyL1BkDqFpGQ2JmYYp2LxFf4onR34qlRG9sBgU8LOoqqNcGiZyAYmTOpsYRn qgycw3MH7hT+NTcDvmvYoapgpMotYhBYqrVFh/ehD4Al6RNvXanG2LKhbmlGUjXSfIIX xmeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CXckkpdf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id p11-20020a170902ebcb00b00163fbb1f1fasi10399217plg.252.2022.06.07.22.10.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 22:10:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CXckkpdf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3CE8F6CF74; Tue, 7 Jun 2022 21:41:20 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350740AbiFGSYY (ORCPT + 99 others); Tue, 7 Jun 2022 14:24:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350239AbiFGSAt (ORCPT ); Tue, 7 Jun 2022 14:00:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 775846129D; Tue, 7 Jun 2022 10:42:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4335CB81F38; Tue, 7 Jun 2022 17:42:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A611AC385A5; Tue, 7 Jun 2022 17:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654623756; bh=3os4nm//VWdtnukH4DMduEp3AKayG5T+pbN7X5F8Egs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CXckkpdf9DqDh2geOMFNKWhUonFOF9KphdihsU7b2bNtYneDkAzXlY07lHrybfajr 7tjey177Lw1iToZO8t4IhDhIKASc/Kyy1L/fwGZXlVB0ZtnSrtJqGzs77lrKMh1KGd qO3pCdwQLY2d6mpGcoarUojuDrX/nCXioWxj4/+k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vignesh Raghavendra , Aswath Govindraju , Ulf Hansson , Sasha Levin Subject: [PATCH 5.15 079/667] drivers: mmc: sdhci_am654: Add the quirk to set TESTCD bit Date: Tue, 7 Jun 2022 18:55:44 +0200 Message-Id: <20220607164937.189911146@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164934.766888869@linuxfoundation.org> References: <20220607164934.766888869@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vignesh Raghavendra [ Upstream commit c7666240ec76422cb7546bd07cc8ae80dc0ccdd2 ] The ARASAN MMC controller on Keystone 3 class of devices need the SDCD line to be connected for proper functioning. Similar to the issue pointed out in sdhci-of-arasan.c driver, commit 3794c542641f ("mmc: sdhci-of-arasan: Set controller to test mode when no CD bit"). In cases where this can't be connected, add a quirk to force the controller into test mode and set the TESTCD bit. Use the flag "ti,fails-without-test-cd", to implement this above quirk when required. Signed-off-by: Vignesh Raghavendra Signed-off-by: Aswath Govindraju Link: https://lore.kernel.org/r/20220425063120.10135-3-a-govindraju@ti.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/sdhci_am654.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index b4891bb26648..a3e62e212631 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -147,6 +147,9 @@ struct sdhci_am654_data { int drv_strength; int strb_sel; u32 flags; + u32 quirks; + +#define SDHCI_AM654_QUIRK_FORCE_CDTEST BIT(0) }; struct sdhci_am654_driver_data { @@ -369,6 +372,21 @@ static void sdhci_am654_write_b(struct sdhci_host *host, u8 val, int reg) } } +static void sdhci_am654_reset(struct sdhci_host *host, u8 mask) +{ + u8 ctrl; + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_am654_data *sdhci_am654 = sdhci_pltfm_priv(pltfm_host); + + sdhci_reset(host, mask); + + if (sdhci_am654->quirks & SDHCI_AM654_QUIRK_FORCE_CDTEST) { + ctrl = sdhci_readb(host, SDHCI_HOST_CONTROL); + ctrl |= SDHCI_CTRL_CDTEST_INS | SDHCI_CTRL_CDTEST_EN; + sdhci_writeb(host, ctrl, SDHCI_HOST_CONTROL); + } +} + static int sdhci_am654_execute_tuning(struct mmc_host *mmc, u32 opcode) { struct sdhci_host *host = mmc_priv(mmc); @@ -500,7 +518,7 @@ static struct sdhci_ops sdhci_j721e_4bit_ops = { .set_clock = sdhci_j721e_4bit_set_clock, .write_b = sdhci_am654_write_b, .irq = sdhci_am654_cqhci_irq, - .reset = sdhci_reset, + .reset = sdhci_am654_reset, }; static const struct sdhci_pltfm_data sdhci_j721e_4bit_pdata = { @@ -719,6 +737,9 @@ static int sdhci_am654_get_of_property(struct platform_device *pdev, device_property_read_u32(dev, "ti,clkbuf-sel", &sdhci_am654->clkbuf_sel); + if (device_property_read_bool(dev, "ti,fails-without-test-cd")) + sdhci_am654->quirks |= SDHCI_AM654_QUIRK_FORCE_CDTEST; + sdhci_get_of_property(pdev); return 0; -- 2.35.1