Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220604145624.47326-1-robimarko@gmail.com> <a08c5dd0-279d-724a-4836-6e66bfa183e8@wanadoo.fr>
In-Reply-To: <a08c5dd0-279d-724a-4836-6e66bfa183e8@wanadoo.fr>
From:   Robert Marko <robimarko@gmail.com>
Date:   Tue, 7 Jun 2022 14:42:38 +0200
Message-ID: <CAOX2RU5zUMEVZeScSPV6MvzvxwghECJy1DHDTfW5CFDeyPuE+A@mail.gmail.com>
Subject: Re: [PATCH 1/3] regulator: mp5416: alphabetically sort header includes
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     sravanhome@gmail.com, lgirdwood@gmail.com, broonie@kernel.org,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, 4 Jun 2022 at 17:41, Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Le 04/06/2022 =C3=A0 16:56, Robert Marko a =C3=A9crit :
> > Sort the header include list alphabetically.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> >   drivers/regulator/mp5416.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/regulator/mp5416.c b/drivers/regulator/mp5416.c
> > index 39cebec0edb6..d8245080df03 100644
> > --- a/drivers/regulator/mp5416.c
> > +++ b/drivers/regulator/mp5416.c
> > @@ -6,14 +6,14 @@
> >   //
> >   // Author: Saravanan Sekar <sravanhome@gmail.com>
> >
> > +#include <linux/err.h>
> > +#include <linux/i2c.h>
> > +#include <linux/init.h>
> >   #include <linux/kernel.h>
>
> Nitpick: it seems that kernel.h is not needed here. (at least it compile
> without it).

Hi,

It also seems to work fine without it, will send a patch to remove it.

Regards,
Robert
>
> CJ
>
> >   #include <linux/module.h>
> > -#include <linux/init.h>
> > -#include <linux/err.h>
> >   #include <linux/platform_device.h>
> >   #include <linux/regmap.h>
> >   #include <linux/regulator/driver.h>
> > -#include <linux/i2c.h>
> >
> >   #define MP5416_REG_CTL0                     0x00
> >   #define MP5416_REG_CTL1                     0x01
>