Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2181219iof; Tue, 7 Jun 2022 22:23:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjw7dud8QIlPbP0oUsOidSzIk36MwUw3VZjK+0yE68E/geMx/SRg9btDGcxVya3Pemem9S X-Received: by 2002:a63:5711:0:b0:3fd:b97e:3c0c with SMTP id l17-20020a635711000000b003fdb97e3c0cmr12297191pgb.570.1654665831626; Tue, 07 Jun 2022 22:23:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654665831; cv=none; d=google.com; s=arc-20160816; b=Qzjuv4YC35VS+eA0yQb+ikCJI9xj/vyuro4z2t5fzJmkuHxkCKufZGZE9beWmQoHx7 enLXtCnIR95ts+WwbuUrDMB79/b3r2BeYnG3amvRtr3noRmZuVH5ACZftIBvWFTMuhC4 MXwjAVv0kttWWeYjSIUIkeuSQ8iD+Sj4l5MyhKV+CyDaCatOdnfzkgPP2kwf4vf123SE I/7vJym6hqjoWIO1nQKKDJ4ZGMsxcvVEB+IlZGCGiCtyyOZzR99YsMgflN+Cb19kCwz6 5i7xk6gwxazzgn7yIMgm4B3pKdne20ek3HWQZIOmSHpdzntbfliD3hlFU6v0GBcHXgww vZtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3KKOmxSOfKHj3Xd+NqMIvw/0/srTRIWnSazj3cAllPc=; b=FXVPIGuDHi8OU5VT1lI69k2PzrhT4xBHvN4m3oTlIOYzYEX+uF6ySK/EZq4pSkmA0Z 972SAulUNToHrT/lY3+cNlhjdUJEfINxRrqXumF7agT2laypwZIFAxM1pyosFqjuS5/Y k1HTzzH7pVrd9cgWBEcT/JWHOv+TVQorXEJJOhfgw2Bbg1UHuNOu4nTx3PKL9QULrtAA nYItIoJ3DiayLQEMZm96QntrDbT5mzlBdA+OeP29VcQynREgdOAtkS2aRr8GjbnH3bmM N14bnJ1H+8FUqWfexgEJB7ne4EGhJBiD7TtFEgbCZfTyGBLAYM4dIa1RJwGiWBKrK9zc 4hww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X+TgXaN5; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id z5-20020a170903018500b0016250c76ae6si17918959plg.367.2022.06.07.22.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 22:23:51 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X+TgXaN5; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 84BFC4759FE; Tue, 7 Jun 2022 21:52:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356608AbiFGUWk (ORCPT + 99 others); Tue, 7 Jun 2022 16:22:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356208AbiFGTbZ (ORCPT ); Tue, 7 Jun 2022 15:31:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE2B713F56; Tue, 7 Jun 2022 11:12:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA7C160906; Tue, 7 Jun 2022 18:12:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7576C385A2; Tue, 7 Jun 2022 18:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654625538; bh=EI6kyMEv2r+oMfMB12oZQKomnwfH3xTNuKb7+f/Swr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X+TgXaN5jYES8Czh14xTediXu+sa4cWUOvaxSqtgo/B1Y0UJOqBfuJF7a/RPXUEQU yH8Dc9S/QRybCjj7A5huPC8nGA0t3a+u1wZC6eO8akr3JzwKc0QWZGndmrAtBo+Kbb QofEsYOpVWj8oQw1PX4w4SO0Q51l8MpaD1JBCJKc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nikolay Borisov , Andrii Nakryiko , Sasha Levin Subject: [PATCH 5.17 054/772] selftests/bpf: Fix vfs_link kprobe definition Date: Tue, 7 Jun 2022 18:54:06 +0200 Message-Id: <20220607164950.631934237@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164948.980838585@linuxfoundation.org> References: <20220607164948.980838585@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nikolay Borisov [ Upstream commit e299bcd4d16ff86f46c48df1062c8aae0eca1ed8 ] Since commit 6521f8917082 ("namei: prepare for idmapped mounts") vfs_link's prototype was changed, the kprobe definition in profiler selftest in turn wasn't updated. The result is that all argument after the first are now stored in different registers. This means that self-test has been broken ever since. Fix it by updating the kprobe definition accordingly. Signed-off-by: Nikolay Borisov Signed-off-by: Andrii Nakryiko Link: https://lore.kernel.org/bpf/20220331140949.1410056-1-nborisov@suse.com Signed-off-by: Sasha Levin --- tools/testing/selftests/bpf/progs/profiler.inc.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/profiler.inc.h b/tools/testing/selftests/bpf/progs/profiler.inc.h index 4896fdf816f7..92331053dba3 100644 --- a/tools/testing/selftests/bpf/progs/profiler.inc.h +++ b/tools/testing/selftests/bpf/progs/profiler.inc.h @@ -826,8 +826,9 @@ int kprobe_ret__do_filp_open(struct pt_regs* ctx) SEC("kprobe/vfs_link") int BPF_KPROBE(kprobe__vfs_link, - struct dentry* old_dentry, struct inode* dir, - struct dentry* new_dentry, struct inode** delegated_inode) + struct dentry* old_dentry, struct user_namespace *mnt_userns, + struct inode* dir, struct dentry* new_dentry, + struct inode** delegated_inode) { struct bpf_func_stats_ctx stats_ctx; bpf_stats_enter(&stats_ctx, profiler_bpf_vfs_link); -- 2.35.1