Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2188601iof; Tue, 7 Jun 2022 22:37:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoNQM+fbKRaLvns8oa96WHmGnyPteqmy3b1LqlHxVaYjvu11CWFLBgyILv6/A7ZitjYq7e X-Received: by 2002:a17:90b:1a8a:b0:1e8:9388:5b5b with SMTP id ng10-20020a17090b1a8a00b001e893885b5bmr11773872pjb.50.1654666620966; Tue, 07 Jun 2022 22:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654666620; cv=none; d=google.com; s=arc-20160816; b=0Nf/q/B+UaQxyasnJIPXB/4MplOPdFo6e9EOIpkRboIR9pkNKoZj9nmAERbCSG5hmm 2+wLEt6D5S5oSDZ37XJxK4FBgPObFsyfnrCKEU5FqdcNHWiR2vaojYVCqFxsmFdkeHn4 /uNCTL18HKDfLrYSSOEaMma/BfAm00sWzrlax8GpgUKaVY2Y+IO+K69W4wuCWqFcN/iN sG3iZZ9CpI2oMHOJs58MhU/63VWhnue+wrTRvy2GrGIpyKvfxYYlpjsvKEd94yvPfItR KXkIxTftUZVevP5vDxLePxL06pUJQFBxslDku6nbtvVdZO84bTvmQCnhgaEeH5XYCvyC xt3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hKsvqvR2lREsFx1hV0kSUowSgJGJzeJnu8Xq/dLTjug=; b=D9muJeqCCoUfm9W2e74gz7xVIRmoAFwIJuRQ+MY/5ty0KaasCOj8o8KIXaaGgk0lFq UBk/lVAMt4bP+TzyoXpi9tXPd9Fj7uDktBYCgk4pYc7Y6TOf2/6xI4rvLptVJVc/UCwS aAmvvL60nnOdUvjcOn1049jWClzv+czUNwkh4q6EMXi4nXtlJjegzR+Jv+jsgR+Igkw+ oucj4R+szZ3lUtLbF1lFGknQzSkkGoMIVnR04FkYUwWsxZUqmn4kxLv+UtIxuCUlpGSY A1082R/ePM92oI3kJoEkPqeensWc3PAazeHCgeGgQ2Xsjqzgcn009TeXVYtdUfMnNqep tFhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YbBzIZwf; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id o62-20020a62cd41000000b004fac74c8c8asi25504648pfg.329.2022.06.07.22.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 22:37:00 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=YbBzIZwf; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 11D6A311986; Tue, 7 Jun 2022 22:03:09 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355857AbiFGTRg (ORCPT + 99 others); Tue, 7 Jun 2022 15:17:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351218AbiFGS3o (ORCPT ); Tue, 7 Jun 2022 14:29:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F39917A880; Tue, 7 Jun 2022 10:55:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E9056617A8; Tue, 7 Jun 2022 17:55:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01C4CC34119; Tue, 7 Jun 2022 17:55:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654624526; bh=oTUD0gfXlCXXBTlNhj7YdtZdcBIDAMIgu5/THuULMSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YbBzIZwfUBTy9WxiVYKWyPGzXG+a91lfowiF++zDbkjMkbX+LeSwnN32elAFodhNh Z+iYxX8xsIomFeGQHmeJzgtH1BwXjJ1JqRLofzHVLyUTvZ8GcGq8tTVj/C2rVQUqGX mIKKlnKM2M6tGl4h8rM5p7cknypWbCjK0VdfGCk8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ulf Hansson , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.15 360/667] PM: domains: Fix initialization of genpds next_wakeup Date: Tue, 7 Jun 2022 19:00:25 +0200 Message-Id: <20220607164945.552195634@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164934.766888869@linuxfoundation.org> References: <20220607164934.766888869@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ulf Hansson [ Upstream commit 622d9b5577f19a6472db21df042fea8f5fefe244 ] In the genpd governor we walk the list of child-domains to take into account their next_wakeup. If the child-domain itself, doesn't have a governor assigned to it, we can end up using the next_wakeup value before it has been properly initialized. To prevent a possible incorrect behaviour in the governor, let's initialize next_wakeup to KTIME_MAX. Fixes: c79aa080fb0f ("PM: domains: use device's next wakeup to determine domain idle state") Signed-off-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/base/power/domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 7e8039d1884c..0f2e42f36851 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1978,6 +1978,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd, genpd->device_count = 0; genpd->max_off_time_ns = -1; genpd->max_off_time_changed = true; + genpd->next_wakeup = KTIME_MAX; genpd->provider = NULL; genpd->has_provider = false; genpd->accounting_time = ktime_get(); -- 2.35.1