Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 07 Jun 2022 11:09:45 +0200
Message-ID: <87h74won52.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     huangwenhui <huangwenhuia@uniontech.com>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        kailang@realtek.com, tanureal@opensource.cirrus.com,
        jeremy.szu@canonical.com, linux-kernel@vger.kernel.org,
        wse@tuxedocomputers.com, hui.wang@canonical.com, sami@loone.fi,
        cam@neo-zeon.de
Subject: Re: [PATCH] ALSA: hda/realtek - Add HW8326 support
In-Reply-To: <20220607084109.29120-1-huangwenhuia@uniontech.com>
References: <20220607084109.29120-1-huangwenhuia@uniontech.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 07 Jun 2022 10:41:09 +0200,
huangwenhui wrote:
> 
> Added the support of new Huawei codec HW8326.
> 

It'd be appreciated if you describe about the hardware a bit more.
It looks like a compatible chip with some other Realtek codecs
(ALC256?).

> @@ -11479,6 +11492,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
>  	HDA_CODEC_ENTRY(0x10ec0236, "ALC236", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0245, "ALC245", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0255, "ALC255", patch_alc269),
> +	HDA_CODEC_ENTRY(0x19e58326, "HW8326", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0256, "ALC256", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0257, "ALC257", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0260, "ALC260", patch_alc260),

This table is sorted in the codec ID order.  Please put at the
appropriate place (at the last), instead.


thanks,

Takashi