Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2196051iof; Tue, 7 Jun 2022 22:53:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBbBe3BlEdebd9ZTHjsEob9mP9PQ4frCB6x+fgMiXCt7dvq8ij23tZteRO3rWQ8D3axjCb X-Received: by 2002:a05:6a00:168a:b0:4f7:e161:83cd with SMTP id k10-20020a056a00168a00b004f7e16183cdmr33390224pfc.56.1654667592250; Tue, 07 Jun 2022 22:53:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654667592; cv=none; d=google.com; s=arc-20160816; b=ibwqkfn/ZpOL75FSMHfJaYnHykXP8cHHbeekJ7R5q8Y35Z9Hh0U99NH9LYoJEcf772 0ZzOLBbMCYuxidfzpIKLpgG6FRdCcTXA9YaV1f+gzPDOqckQyPTTZYyo0Ib5f3paPPHv M25N+Hy9aN6wTXd9JJmZK3uyfwQyPQzku4c7vxf9yPtIBV1+MI5ynutOHPJRuXHyASr8 gaHKBMPZtIHekURsaF+ba8NDwxBReJAg0xbMGMeGeGRWPwGKHUHy/Im39d/Oc3L9vIdM XgxW3zPJQN8XFhVigid/xE5W4lnSn9gqkbEFu+4fOqYv9SiJtk5CY+vZfOUjdV8tqvY2 rHVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w84ztkvAVEYq/AF2H5IBUF9o6/WhZdtpVEjKM1yQl18=; b=jnyegeE+4OEADsKJ9ICdAWZH1WbJEQ6JKQALiOmc9/fNKTT7VAcKpqGio6L4qws6tf /ugfmLmnU3mlzoUNmFmx+5h05wWcm/C5EDTncrSTSPR2gaA3fcuwqz7THdSWp6DUdpFa PxWfVOIaC82pop5tOvkLVJhg6Id/4qvkIS0ci/nYQpqclFFWRZ1iCRDGsXwHfnXrzB5v ONOhWL/BqXEt3Xo5iG/HxJ1gfgZl04cdQ9c6D8xgR7xay8C2TEUKuZpb5Dx7xNx6DGeG 62sSjw68Q7XUi9wY3f6BlS/0P8KQqtTet08xBpgt9bnxXJGhXar1IhBrmQ/7VB3LTfD7 b69Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GUnPt7cN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h7-20020a170902f70700b00163e05df91asi25942868plo.37.2022.06.07.22.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 22:53:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GUnPt7cN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E047F417CFF; Tue, 7 Jun 2022 22:19:51 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442248AbiFHAyL (ORCPT + 99 others); Tue, 7 Jun 2022 20:54:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382418AbiFGWCh (ORCPT ); Tue, 7 Jun 2022 18:02:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15D49128144; Tue, 7 Jun 2022 12:14:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1B8D61807; Tue, 7 Jun 2022 19:14:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB038C385A2; Tue, 7 Jun 2022 19:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654629280; bh=conex0sFGgB/DV350k7ij59++tfMZbwt9/zyaSY9Pe8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GUnPt7cNXgGjXoZBZFj3OpHKLd6gkdIEe3LKbmqugKRUybbfX5PBIMgiga7CHN6Tz KLd9sb/c/AyFUhQopBn67JdQlGCTsJZrP0P4XWUzE/o/iJ259Nn982vXndm0uxn6SN tTDa3UjeEZr0m2TfeAZDwE4fqOxLhnLZDx6clYqQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Linus Walleij , Sasha Levin Subject: [PATCH 5.18 593/879] pinctrl: mvebu: Fix irq_of_parse_and_map() return value Date: Tue, 7 Jun 2022 19:01:51 +0200 Message-Id: <20220607165020.065562054@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607165002.659942637@linuxfoundation.org> References: <20220607165002.659942637@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 71bc7cf3be65bab441e03667cf215c557712976c ] The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO. Fixes: 2f227605394b ("pinctrl: armada-37xx: Add irqchip support") Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20220422105339.78810-1-krzysztof.kozlowski@linaro.org Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 08cad14042e2..adccf03b3e5a 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -773,7 +773,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev, for (i = 0; i < nr_irq_parent; i++) { int irq = irq_of_parse_and_map(np, i); - if (irq < 0) + if (!irq) continue; girq->parents[i] = irq; } -- 2.35.1