Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2204846iof; Tue, 7 Jun 2022 23:09:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwu50BlQ/2iju0duV1CohOGmR+Kr7nWr5pk+m5kNj/chDLtF81Poi7baVUQmAYT33KoE8dK X-Received: by 2002:a17:90a:1588:b0:1e0:a45c:5c1 with SMTP id m8-20020a17090a158800b001e0a45c05c1mr36559223pja.65.1654668541587; Tue, 07 Jun 2022 23:09:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654668541; cv=none; d=google.com; s=arc-20160816; b=zkpB/udHietcUPWtx2IpJFtm6Yh4sH9pF2/F+59FqAiHzXc9C6RmLBBbyAuYS5ASJJ YZs/dUxwDr8jkWlyJJcTxdHJ+558RffnVC98WY6orkri6FM/3lqe/4iBQnH5p1fA9nuc Mz4Um4/F5VtrrHTLybhjKVdI506X42Ixz7rsnEidHbdP+MHiKya97vhTaQAJ5BjAUipE sQuZPTE54+FY3D5jVGpxV2rH6mmX5LgFBHxGeI3N4syWtB3klEVb3o0aFQZgQxOt41zc GqlhK3KCkDFLz94NbBJhko1rPjXn7X2+0tdP2ZUT/jPOJf5Gor2dBksD2yc3ZUz+Z7sz ql8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zAz5OVwMlsFhYT7KeeJB4vJfaC4h4HtrBACingourjY=; b=rZUHN5Tk3r8OK4xvEj8Hmv2qDpMYDEi0NGx8EjSHVmczDag/V1w1VPSznFynVTpZm8 BnhWG2CDTCtBF/QJL6QMQqSM08iQNpaHzWKrfnHWhXHYJyumdhfR8S/NqzusK5t/cxJl cAui/3Cxngj9/JMAzDaZBV/gWWEUc6h940YeMZhDDB5hYFi6yNjVAyX/huGKdwV0xEiK DZ5wXtf4qAplX3EN8o41dyzgtPsdKshDjob2sYNHwlGphOPrBTaTJeumcd2OAOVlJXNS MCrg4y+Npqy48zzbRVeBGkD50wFomoZsYeJxXMxQFpWJ3vNXV4DxdZgbcpRpHCkfe9hC 9ezw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y130gQC9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 18-20020a621712000000b0050d932fc7b4si23680472pfx.185.2022.06.07.23.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 23:09:01 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y130gQC9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8363B2122AA; Tue, 7 Jun 2022 22:31:51 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386548AbiFHB0c (ORCPT + 99 others); Tue, 7 Jun 2022 21:26:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383751AbiFGWa7 (ORCPT ); Tue, 7 Jun 2022 18:30:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B62FE276214; Tue, 7 Jun 2022 12:24:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EFE2FB8220B; Tue, 7 Jun 2022 19:24:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D7C5C385A2; Tue, 7 Jun 2022 19:24:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654629843; bh=NSpYyGGJXBbVhvCEmdzTJ3lzz03ll/lczQXkZqe5C3Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y130gQC9MMaLUQZiMFr6wW5WfjvF8l3Sxvt5ilHDaX+vN4waDYgnhGxJp5M2UqeSn +0jYQh3cjctslnR5oOQ2HynNUNwunvd/ZHLsiG+l9F04QyRNgsBpPpUsoaFnf8fViY pCPKa+9FM5KTqE0FFBhRb4kVpeP0dqTKdEr6iCcI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mark Brown Subject: [PATCH 5.18 836/879] ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control Date: Tue, 7 Jun 2022 19:05:54 +0200 Message-Id: <20220607165027.121124945@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607165002.659942637@linuxfoundation.org> References: <20220607165002.659942637@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown commit 4213ff556740bb45e2d9ff0f50d056c4e7dd0921 upstream. The driver has a custom put function for "DSP Voice Wake Up" which does not generate event notifications on change, instead returning 0. Since we already exit early in the case that there is no change this can be fixed by unconditionally returning 1 at the end of the function. Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220428162444.3883147-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/codecs/rt5514.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/codecs/rt5514.c +++ b/sound/soc/codecs/rt5514.c @@ -419,7 +419,7 @@ static int rt5514_dsp_voice_wake_up_put( } } - return 0; + return 1; } static const struct snd_kcontrol_new rt5514_snd_controls[] = {