Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <CAPM=9tw62EZfAm0PbiOPmMrpfR98QMFTWGEQcA34G4ap4xxNkA@mail.gmail.com>
 <CAMuHMdXb5-gOVRsQx6tDqjQMD9cC-p=o56VuF2cBPWyMFRgHMA@mail.gmail.com> <CAHk-=wgcv_YewP0rgwR1+gj3YF-7Jz8WPVzDgndx0DVMVKzV=Q@mail.gmail.com>
In-Reply-To: <CAHk-=wgcv_YewP0rgwR1+gj3YF-7Jz8WPVzDgndx0DVMVKzV=Q@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 7 Jun 2022 21:12:14 +0200
Message-ID: <CAMuHMdU-HQZ3ZozS8AEP2P6aU3eMp6jO-GYOCOFOju_rcxOg+w@mail.gmail.com>
Subject: Re: [git pull] drm for 5.19-rc1
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Dave Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Linus,

On Tue, Jun 7, 2022 at 8:15 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Tue, Jun 7, 2022 at 3:23 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > These header files are heavy users of large constants lacking the "U"
> > suffix e.g.:
> >
> >     #define NB_ADAPTER_ID__SUBSYSTEM_ID_MASK 0xFFFF0000L
>
> As Andreas says, this is not undefined behavior.
>
> A hexadecimal integer constant will always get a type that fits the
> actual value. So on a 32-bit architecture, because 0xFFFF0000 doesn't
> fit in 'long', it will automatically become 'unsigned long'.
>
> Now, a C compiler might still warn about such implicit type
> conversions, but I'd be a bit surprised if any version of gcc actually
> would do that, because this behavior for hex constants is *very*
> traditional, and very common.
>
> It's also true that the type of the constant - but not the value -
> will be different on 32-bit and 64-bit architectures (ie on 64-bit, it
> will be plain "long" and never extended to "unsigned long", because
> the hex value obviously fits just fine).
>
> I don't see any normal situation where that really matters, since any
> normal use will have the same result.
>
> The case you point to at
>
>   https://lore.kernel.org/r/CAK8P3a0QrihBR_2FQ7uZ5w2JmLjv7czfrrarCMmJOhvNdJ3p9g@mail.gmail.com
>
> is very different, because the constant "1" is always just a plain
> signed "int". So when you do "(1 << 31)", that is now a signed integer
> with the top bit set, and so it will have an actual negative value,
> and that can cause various problems (when right-shifted, or when
> compared to other values).
>
> But hexadecimal constants can be signed types, but they never have
> negative values.

Thank you, I stand corrected.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds