Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 7 Jun 2022 23:02:31 +0200
From:   Stephen Kitt <steve@sk2.org>
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     Robin van der Gracht <robin@protonic.nl>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] auxdisplay: ht16k33: Use backlight helper
Message-ID: <20220607230231.07e36338@heffalump.sk2.org>
In-Reply-To: <CANiq72kRhmT37H1FAGYGny83ONYXeqJuO8ZPbym0ajQOWKY4Kw@mail.gmail.com>
References: <20220607180406.1116277-1-steve@sk2.org>
        <CANiq72kRhmT37H1FAGYGny83ONYXeqJuO8ZPbym0ajQOWKY4Kw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/PUlUnIq0mXPgwAmIA0b49MF";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/PUlUnIq0mXPgwAmIA0b49MF
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Miguel,

On Tue, 7 Jun 2022 21:08:34 +0200, Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
> On Tue, Jun 7, 2022 at 8:04 PM Stephen Kitt <steve@sk2.org> wrote:
> > backlight_properties.fb_blank is deprecated. The states it represents
> > are handled by other properties; but instead of accessing those
> > properties directly, drivers should use the helpers provided by
> > backlight.h.
> >
> > Instead of retrieving the backlight brightness in struct
> > backlight_properties manually, and then checking whether the backlight
> > should be on at all, use backlight_get_brightness() which does all
> > this and insulates this from future changes. =20
>=20
> Thanks for the patch! Looks good to me.
>=20
> There is a functional change in that `BL_CORE_SUSPENDED` is taken into
> account with this change, but I assume that is expected. In that case,
> it could be good to mention it in the commit message.

That=E2=80=99s a good point, and it is indeed expected; I=E2=80=99ll add it=
 to the commit
message.

Regards,

Stephen

--Sig_/PUlUnIq0mXPgwAmIA0b49MF
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEnPVX/hPLkMoq7x0ggNMC9Yhtg5wFAmKfvOcACgkQgNMC9Yht
g5zYOQ/9H3YNK2TyqQSG4j7HQk9Wj4DrSnbALPbkQ+Ej+PNa/OrE5SDk+bfhFJig
Ctiu1ja2SQHnCoda0Wxy9FuXJXNXp9YNO64Bo1GrQ6zSSNJO5MiDBr82HwF2GfvU
sbLnsDipylStz7F5+qHfVbUSFvWT3xOFZJwB62JiSrNL5Y7qQr3OR+50BW1s2gid
rU9MPTfyRBkIeR/JrkyN2ZO1TZweAhVFzn5QVfOxCBmdE1Qzj1Drw9+C3wxaXtfL
rsLhUaBcvUi0xl9BCavgB/Zk+dIq0k9jXJKOyddp/M0utEf9daCPJswN85I98RKe
mhKWACHvx8zTh1G7/86+hyV8VLhG995zuPW13TMRR5hSJ3RIGyadwo/MAw8+3Jaf
31F3g+0e/cbux4a8WRu2VOICrbv9ZfYf6LG9dN3qyj7uwujVMfAbR4j2tphxOIb0
Z0T85E+gr82uZHDVT7Hyr+cK/dSSxhYU6xjW+ywdlXjGLy86qVr2QwTBjUxRI35I
aPLrarw8prP3nch47JnfUsfjO65vXqcy9/EHY4FjwFuxRjbxisY7VDZw458suid6
yk7VdYU/EAYhj2I9E6+NZEtQVCV/XnMqZw7Ma82aHf/7HRWuOkat10PpPXH/mnN1
XOkR6MTcxLz89MqCZIu5+HyY/haBcWSpq5WCd4U3oPm7jnVG2+8=
=//gF
-----END PGP SIGNATURE-----

--Sig_/PUlUnIq0mXPgwAmIA0b49MF--