Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [PATCH v5 0/7] can: refactoring of can-dev module and of Kbuild
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        linux-can <linux-can@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Max Staudt <max@enpas.org>, netdev <netdev@vger.kernel.org>
References: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr>
 <20220604163000.211077-1-mailhol.vincent@wanadoo.fr>
 <2e8666f3-1bd9-8610-6b72-e56e669d3484@hartkopp.net>
 <CAMZ6RqKWUyf6dZmxG809-yvjg5wbLwPSLtEfv-MgPpJ5ra=iGQ@mail.gmail.com>
 <f161fdd0-415a-8ea1-0aad-3a3a19f1bfa8@hartkopp.net>
 <20220607202706.7fbongzs3ixzpydm@pengutronix.de>
From:   Oliver Hartkopp <socketcan@hartkopp.net>
Message-ID: <44670e69-6d67-c6c7-160c-1ae6e740aabb@hartkopp.net>
Date:   Tue, 7 Jun 2022 22:51:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20220607202706.7fbongzs3ixzpydm@pengutronix.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07.06.22 22:27, Marc Kleine-Budde wrote:
> On 07.06.2022 22:12:46, Oliver Hartkopp wrote:
>> So what about:
>>
>>    symbol: CONFIG_NETDEVICES
>>    |
>>    +-> CAN Device Drivers
>>        symbol: CONFIG_CAN_DEV
>>        |
>>        +-> software/virtual CAN device drivers
>>        |   (at time of writing: slcan, vcan, vxcan)
>>        |
>>        +-> hardware CAN device drivers with Netlink support
>>            symbol: CONFIG_CAN_NETLINK (matches previous CONFIG_CAN_DEV)
>>            |
>>            +-> CAN bit-timing calculation (optional for all drivers)
>>            |   symbol: CONFIG_CAN_BITTIMING
>>            |
>>            +-> CAN rx offload (optional but selected by some drivers)
>>            |   symbol: CONFIG_CAN_RX_OFFLOAD
>>            |
>>            +-> CAN devices drivers
>>                (some may select CONFIG_CAN_RX_OFFLOAD)
>>
>> (I also added 'hardware' to CAN device drivers with Netlink support) to have
>> a distinction to 'software/virtual' CAN device drivers)
> 
> The line between hardware and software/virtual devices ist blurry, the
> new can327 driver uses netlink and the slcan is currently being
> converted....

Right, which could mean that slcan and can327 should be located in the 
'usual' CAN device driver section and not in the sw/virtual device section.

The slcan and can327 need some kind of hardware - while vcan and vxcan 
don't.

Best regards,
Oliver