Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2227690iof; Tue, 7 Jun 2022 23:51:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyi/FxV2EhGqKwBEt6orkWG+FhRTFEWH5ta6uB4pTawr3sYIq1UfwmhPlBJvLT6/BbDYdh9 X-Received: by 2002:a17:906:e097:b0:70a:6e59:4c85 with SMTP id gh23-20020a170906e09700b0070a6e594c85mr24133172ejb.323.1654671081413; Tue, 07 Jun 2022 23:51:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654671081; cv=none; d=google.com; s=arc-20160816; b=YsEdZwuvv2DDHXwYFua0Mmyirbso9I8d69764rIAWmp85UmBNUQUupLH0oHGjpekDb c1V1OfMxIghkF6THvXAgh7rmmdKgQra/MON9q/HF6OF6mzF5+2YEhQjJsclBBYbO4cZB TymglFhagBL5Gpn2JTe3URn1e2vz7QUI4oky3+5a8J+E3wBA6Gh7KAEPPdt8XXcGcrQR 6+QyPW1BHxFrRkBWoN5ENGV6Wf1KXS4jlNohr1smbOM0jUfpi+3/rtXW+ECKTqvgyPyM 76DUb7tRfrUSb9P0uvISAmGQIE5YhCWOAlV76ysT4UhmNtemP0RdULVRO0SmAD4vzKhG hApQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zAz5OVwMlsFhYT7KeeJB4vJfaC4h4HtrBACingourjY=; b=e1og2nILn48hP1pqfl37YUFLM0ocXeBqU2zUzmJONiV/qMizfQtQZgXmguDWupR4Ds NL9Y393FoJXqdGJ3pzJyUsr5KxfdOIeobXYnF25c3rVmuJ6lkFHQ3bYVzCqIgEo0zTNM 0xEkb3dHKe7FLF/KGpADWZ6lKm2U1w1t8JuvsU7zkspqu2BzdvlRntMZDT6oEscid/BM xZZdF02sFnw7QccxY0VaqNkJafjl4XxlgZCE/yXodaaQ9CQPRikhdinIRcNDeovyrKC5 GUEWdBZC9P2nxpMc1vlJzLT5uuMfp0Odh14GWo6YfSKtkVIEbjtXANxkSUhvmtbAtbSV zV2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OZUnBJLR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s11-20020a056402164b00b0042ae36e2432si20955734edx.132.2022.06.07.23.50.55; Tue, 07 Jun 2022 23:51:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OZUnBJLR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349816AbiFGSH4 (ORCPT + 99 others); Tue, 7 Jun 2022 14:07:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349164AbiFGRqs (ORCPT ); Tue, 7 Jun 2022 13:46:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02A0B9FF3; Tue, 7 Jun 2022 10:36:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F3FEB60DB5; Tue, 7 Jun 2022 17:36:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10C39C34115; Tue, 7 Jun 2022 17:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654623412; bh=NSpYyGGJXBbVhvCEmdzTJ3lzz03ll/lczQXkZqe5C3Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OZUnBJLRURvWF7w0fn74XVtshmjRCL2cPTIgDFRvIBxoY0K33H4gZCpj7IY8Yj3C4 qn21vxIeDpLQAHoTqrDLJ6ez20+RETtt/+edJEMq20yx/GtJmCcxRrR6KqkT5ah2bg DqH1hw8GdANnSbK7mxK22SPqDZnwR0Z7fOjLZbME= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mark Brown Subject: [PATCH 5.10 407/452] ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control Date: Tue, 7 Jun 2022 19:04:24 +0200 Message-Id: <20220607164920.687855439@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220607164908.521895282@linuxfoundation.org> References: <20220607164908.521895282@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown commit 4213ff556740bb45e2d9ff0f50d056c4e7dd0921 upstream. The driver has a custom put function for "DSP Voice Wake Up" which does not generate event notifications on change, instead returning 0. Since we already exit early in the case that there is no change this can be fixed by unconditionally returning 1 at the end of the function. Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220428162444.3883147-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/codecs/rt5514.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/codecs/rt5514.c +++ b/sound/soc/codecs/rt5514.c @@ -419,7 +419,7 @@ static int rt5514_dsp_voice_wake_up_put( } } - return 0; + return 1; } static const struct snd_kcontrol_new rt5514_snd_controls[] = {