Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2252143iof; Wed, 8 Jun 2022 00:32:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZAa+uCxKtrfJgOGLCRwEEfOM9/4kuubyXoH5vcgsZL9u4N/uAHbkfAZYUAKfUErQWl0m3 X-Received: by 2002:a17:90b:1d90:b0:1e8:5a44:820e with SMTP id pf16-20020a17090b1d9000b001e85a44820emr22370668pjb.217.1654673538769; Wed, 08 Jun 2022 00:32:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654673538; cv=none; d=google.com; s=arc-20160816; b=z5aF+eL6IiXc0FqxIanH1DoX5gVtuRyItBE6hF2xb1ysj9gUCvDYtB7M2yi5+BaI9T qeBmiXF3M10kF/tQQ2jMUL555SU+CVQlnuQ+XsmzslsPziKLG+50xD2XXDEk+aEKR57t CEI0ehnAMae+9UV1eqzfi7Ts+EBGLKnYjJxjtyRqoFv1CmvzWedeqGkgX4+CnM8YYE+Q T1JhHwdkMRaiTGn7wDgKM3UlJKNz+lAq705cOCD2eACrgc/Z/bCByxIv8aqO4JOS/PXN R3HyjXyPWZ2RAU9W+c3xYZbGtrxyPKK0HPy04p0ImkLsxnGM3oNXa10mdvCbXXNiPM2g 0+5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lhoa9+Nmr3NQo1+h9F22S3v/h46rD/fHToNoUVcg2sY=; b=INQZSaRyEQx+SPfr2Tjfqpa5ByM14cVbtj1bQjAjp+QZYfAHNZliWdnoYhCzp36YVm acEGp3onaPmrwFQXILwKcsl1H9Qv3lsGwAa/BYpj9e4R86KQa4rx6617VXkSLov2L4my lynudiYu9Zqkyyk0lOXINVlV2XHNbfAeK+94M6VlAVBEOM0VhroZCp5ERNBZcGg8CGgM HsTZC2RyNEi6J7InzPDadomppG2ytY+v5FRc5QP0k7I2FrrF17eE6Alti5aX/M906a8e qjN1OMfaU3PPkSZN3PVZM3ebe8ZO2uShsrJ4wmr6NaFDaLIyUiiWzgYn4HuLXNlWRi3P FXAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dQyluGwX; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id ik14-20020a170902ab0e00b0015830f35108si24581438plb.209.2022.06.08.00.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 00:32:18 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dQyluGwX; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5CF291FE4C4; Wed, 8 Jun 2022 00:04:56 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231834AbiFHDHj (ORCPT + 99 others); Tue, 7 Jun 2022 23:07:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353786AbiFHDBr (ORCPT ); Tue, 7 Jun 2022 23:01:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A70D01D64FC; Tue, 7 Jun 2022 17:30:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EBE766164B; Wed, 8 Jun 2022 00:28:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A23FC34114; Wed, 8 Jun 2022 00:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654648093; bh=XboHJuRyj/Glo0PwahxOUll/k5bf6FTay0X08dtiOi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dQyluGwXqwdjFDgfqmfl3lRH5Y99+gwlU/Dz0WmqBBtFJXHKr2Wr3Y9i5kOs8fOiF yFnpieRFONzgLTz+RC4GD4U81AtfJOspz9wOCQmTQpxqNKMswiPbg2p3QtqCCHPZ1+ 0e+RYd/cIHxJmFqJjptIg4z+2nLVldbECkMBDkmm2kQDU0m6k0cV8qMeP6+ANvfyqZ sAKrcNxYM04wKGvqQXGzSKze2SMicWtg8muGNfwKRHY+pyTr9eOYjXzSQpQzk2Jo6C JJGIGcboRBhEZQWIRwUhEKKzbeVjjYyAwyQ3bzqVyCin2p0Q8F3de8C29AuPJ+U4gc ZlwbemVy5EJDg== Date: Tue, 7 Jun 2022 17:28:12 -0700 From: Jakub Kicinski To: Ronak Doshi Cc: , VMware PV-Drivers Reviewers , "David S. Miller" , Eric Dumazet , Paolo Abeni , open list Subject: Re: [PATCH v2 net-next 5/8] vmxnet3: add command to set ring buffer sizes Message-ID: <20220607172812.489814b9@kernel.org> In-Reply-To: <20220607084518.30316-6-doshir@vmware.com> References: <20220607084518.30316-1-doshir@vmware.com> <20220607084518.30316-6-doshir@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Jun 2022 01:45:15 -0700 Ronak Doshi wrote: > + adapter->ringBufSize.ring1BufSizeType0 = adapter->skb_buf_size; > + adapter->ringBufSize.ring1BufSizeType1 = 0; > + adapter->ringBufSize.ring2BufSizeType1 = PAGE_SIZE; These need to use correct byte ordering helpers, since the fields are __le16 probably cpu_to_le16().